Add methods to TCP and UDP sockets to modify hop limit (refresh of #94678) #138744

Mallets · 2025-03-20T11:18:52Z

#94678 was closed because of time constraints of the original author (@kckeiks).

This PR is a refresh of #94678 where the original proposed changes are ported to the current status of the standard library.

In addition, this PR:

implements the change suggested in add methods to TCP and UDP sockets to modify hop limit #94678 (comment)
defines set_multicast_hop_limit_v6 and multicast_hop_limit_v6 only for UDP sockets and not for TCP sockets as originally proposed

Issue: #139166

rustbot · 2025-03-20T11:19:02Z

r? @ibraheemdev

rustbot has assigned @ibraheemdev.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

ibraheemdev · 2025-03-28T21:46:26Z

r? libs-api because it's been a while since the original PR was approved.

library/std/src/net/tcp.rs

bors · 2025-04-13T08:05:55Z

☔ The latest upstream changes (presumably #139724) made this pull request unmergeable. Please resolve the merge conflicts.

Co-authored-by: David Tolnay <[email protected]>

dtolnay · 2025-04-13T16:23:19Z

Sorry—I missed that this was ready for review again. Please use @rustbot ready, which replaces S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label with S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. .

dtolnay · 2025-04-13T16:24:11Z

@rustbot ready

dtolnay · 2025-04-13T16:25:33Z

Thank you!

@bors r+

bors · 2025-04-13T16:25:35Z

📌 Commit 25fb525 has been approved by dtolnay

It is now in the queue for this repository.

…=dtolnay Add methods to TCP and UDP sockets to modify hop limit (refresh of rust-lang#94678) rust-lang#94678 was closed because of time constraints of the original author (`@kckeiks).` This PR is a refresh of rust-lang#94678 where the original proposed changes are ported to the current status of the standard library. In addition, this PR: - implements the change suggested in rust-lang#94678 (comment) - defines `set_multicast_hop_limit_v6` and `multicast_hop_limit_v6 ` only for UDP sockets and not for TCP sockets as originally proposed Issue: rust-lang#139166

…=dtolnay Add methods to TCP and UDP sockets to modify hop limit (refresh of rust-lang#94678) rust-lang#94678 was closed because of time constraints of the original author (``@kckeiks).`` This PR is a refresh of rust-lang#94678 where the original proposed changes are ported to the current status of the standard library. In addition, this PR: - implements the change suggested in rust-lang#94678 (comment) - defines `set_multicast_hop_limit_v6` and `multicast_hop_limit_v6 ` only for UDP sockets and not for TCP sockets as originally proposed Issue: rust-lang#139166

…enton Rollup of 12 pull requests Successful merges: - rust-lang#138744 (Add methods to TCP and UDP sockets to modify hop limit (refresh of rust-lang#94678)) - rust-lang#138962 (Expect an array when expected and acutal types are both arrays during cast) - rust-lang#139001 (add `naked_functions_rustic_abi` feature gate) - rust-lang#139379 (Use delayed bug for normalization errors in drop elaboration) - rust-lang#139582 (Various coercion cleanups) - rust-lang#139628 (Suggest remove redundant `$()?` around `vis`) - rust-lang#139644 (Micro-optimize `InstSimplify`'s `simplify_primitive_clone`) - rust-lang#139666 (cleanup `mir_borrowck`) - rust-lang#139674 (In `rustc_mir_transform`, iterate over index newtypes instead of ints) - rust-lang#139695 (compiletest: consistently use `camino::{Utf8Path,Utf8PathBuf}` throughout) - rust-lang#139722 (Move some things to rustc_type_ir) - rust-lang#139740 (Convert `tests/ui/lint/dead-code/self-assign.rs` to a known-bug test) r? `@ghost` `@rustbot` modify labels: rollup

ChrisDenton · 2025-04-13T20:30:50Z

failed in rollup #139755 (comment)

@bors r-

Mallets · 2025-04-16T12:52:43Z

I believe I have now fixed the unused_variable error.

dtolnay · 2025-05-25T21:34:10Z

@rustbot ready

dtolnay · 2025-05-25T21:34:38Z

@bors r+

bors · 2025-05-25T21:34:41Z

📌 Commit 6657c75 has been approved by dtolnay

It is now in the queue for this repository.

…=dtolnay Add methods to TCP and UDP sockets to modify hop limit (refresh of rust-lang#94678) rust-lang#94678 was closed because of time constraints of the original author (`@kckeiks).` This PR is a refresh of rust-lang#94678 where the original proposed changes are ported to the current status of the standard library. In addition, this PR: - implements the change suggested in rust-lang#94678 (comment) - defines `set_multicast_hop_limit_v6` and `multicast_hop_limit_v6 ` only for UDP sockets and not for TCP sockets as originally proposed Issue: rust-lang#139166

Rollup of 9 pull requests Successful merges: - #134696 (Implement `normalize_lexically`) - #138744 (Add methods to TCP and UDP sockets to modify hop limit (refresh of #94678)) - #140539 (Simplify `attribute_groups`) - #140863 ([rustdoc] Unify type aliases rendering with other ADT) - #140936 (Clarify WTF-8 safety docs) - #140952 (Specify that split_ascii_whitespace uses the same definition as is_ascii_whitespace) - #141472 (Attempt to improve the `std::fs::create_dir_all` docs related to atomicity) - #141502 (ci: move PR job x86_64-gnu-tools to codebuild) - #141559 (const-check: stop recommending the use of rustc_allow_const_fn_unstable) r? `@ghost` `@rustbot` modify labels: rollup

jhpratt · 2025-05-26T01:37:56Z

@bors r-

#141561 (comment)

Mallets · 2025-08-25T07:12:26Z

Would it be possible to re-kick the CI to get the failure logs?

Refresh of rust-lang#94678

5ce4d0d

rustbot assigned ibraheemdev Mar 20, 2025

rustbot added O-windows Operating system: Windows S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 20, 2025

Mallets mentioned this pull request Mar 20, 2025

feat: Add TTL connection param to multicast eclipse-zenoh/zenoh#1842

Merged

Use IPv6 addresses in hop_limit_v6 docs

03aef02

rustbot added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Mar 28, 2025

rustbot assigned dtolnay and unassigned ibraheemdev Mar 28, 2025

dtolnay requested changes Mar 30, 2025

View reviewed changes

library/std/src/net/tcp.rs Outdated Show resolved Hide resolved

library/std/src/net/tcp.rs Outdated Show resolved Hide resolved

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 30, 2025

Mallets mentioned this pull request Mar 31, 2025

Tracking Issue for #138744: Add methods to TCP and UDP sockets to modify IPv6 hop limits #139166

Open

4 tasks

Update tracking issue to 139166

5ace46a

rustbot added the has-merge-commits PR has merge commits, merge with caution. label Mar 31, 2025

This comment has been minimized.

Sign in to view

Mallets force-pushed the set_ipv6_sock_hop_limit branch from 7f790e2 to 9c1ee90 Compare March 31, 2025 10:13

rustbot removed the has-merge-commits PR has merge commits, merge with caution. label Mar 31, 2025

Update docs according to PR review

25fb525

Co-authored-by: David Tolnay <[email protected]>

dtolnay force-pushed the set_ipv6_sock_hop_limit branch from 9c1ee90 to 25fb525 Compare April 13, 2025 16:23

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 13, 2025

dtolnay approved these changes Apr 13, 2025

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 13, 2025

ChrisDenton mentioned this pull request Apr 13, 2025

Rollup of 13 pull requests #139754

Closed

ChrisDenton mentioned this pull request Apr 13, 2025

Rollup of 12 pull requests #139755

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 13, 2025

Fix unused_variables

6657c75

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 25, 2025

dtolnay approved these changes May 25, 2025

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 25, 2025

jhpratt mentioned this pull request May 25, 2025

Rollup of 9 pull requests #141561

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 26, 2025

Add methods to TCP and UDP sockets to modify hop limit (refresh of #94678) #138744

Are you sure you want to change the base?

Add methods to TCP and UDP sockets to modify hop limit (refresh of #94678) #138744

Uh oh!

Conversation

Mallets commented Mar 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Mar 20, 2025

Uh oh!

ibraheemdev commented Mar 28, 2025

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

bors commented Apr 13, 2025

Uh oh!

dtolnay commented Apr 13, 2025

Uh oh!

dtolnay commented Apr 13, 2025

Uh oh!

dtolnay commented Apr 13, 2025

Uh oh!

bors commented Apr 13, 2025

Uh oh!

ChrisDenton commented Apr 13, 2025

Uh oh!

Mallets commented Apr 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dtolnay commented May 25, 2025

Uh oh!

dtolnay commented May 25, 2025

Uh oh!

bors commented May 25, 2025

Uh oh!

jhpratt commented May 26, 2025

Uh oh!

Mallets commented Aug 25, 2025

Uh oh!

Uh oh!

Mallets commented Mar 20, 2025 •

edited

Loading

Mallets commented Apr 16, 2025 •

edited

Loading