match ergonomics: replace `peel_off_references` with a recursive call #139449

Nadrieril · 2025-04-06T14:02:02Z

This makes it imo quite a bit easier to follow how the binding mode gets calculated.

rustbot · 2025-04-06T14:02:06Z

rustbot has assigned @lcnr.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Nadrieril · 2025-04-06T14:17:41Z

@bors try @rust-timer queue

match ergonomics: replace `peel_off_references` with a recursive call This makes it imo quite a bit easier to follow how the binding mode gets calculated. cc `@dianne`

bors · 2025-04-06T14:18:53Z

⌛ Trying commit fb0d9f5 with merge cfebef6...

bors · 2025-04-06T16:26:22Z

☀️ Try build successful - checks-actions
Build commit: cfebef6 (cfebef6cb0ffedb63fcc11bd2d482f1a85a53249)

rust-timer · 2025-04-06T17:42:20Z

Finished benchmarking commit (cfebef6): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 3.2%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.2%	[3.2%, 3.2%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	3.2%	[3.2%, 3.2%]	1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

Results (secondary 0.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.0%	[0.0%, 0.0%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Bootstrap: 776.062s -> 775.901s (-0.02%)
Artifact size: 365.87 MiB -> 365.91 MiB (0.01%)

Nadrieril · 2025-04-06T18:41:53Z

@rustbot ready

compiler/rustc_hir_typeck/src/pat.rs

lcnr · 2025-04-08T09:24:17Z

r=me after rebase (unless the rebase is non-trivial

lcnr · 2025-04-09T08:08:32Z

@bors r+ rollup

bors · 2025-04-09T08:08:35Z

📌 Commit f458151 has been approved by lcnr

It is now in the queue for this repository.

match ergonomics: replace `peel_off_references` with a recursive call This makes it imo quite a bit easier to follow how the binding mode gets calculated. cc `@dianne`

Rollup of 18 pull requests Successful merges: - rust-lang#137412 (Ensure `swap_nonoverlapping` is really always untyped) - rust-lang#138167 (Small code improvement in rustdoc hidden stripper) - rust-lang#138605 (Clean up librustdoc::html::render to be better encapsulated) - rust-lang#138682 (Allow drivers to supply a list of extra symbols to intern) - rust-lang#138904 (Test linking and running `no_std` binaries) - rust-lang#139423 (Suppress missing field error when autoderef bottoms out in infer) - rust-lang#139449 (match ergonomics: replace `peel_off_references` with a recursive call) - rust-lang#139507 (compiletest: Trim whitespace from environment variable names) - rust-lang#139530 (Remove some dead or leftover code related to rustc-intrinsic abi removal) - rust-lang#139560 (fix title of offset_of_enum feature) - rust-lang#139563 (emit a better error message for using the macro incorrectly) - rust-lang#139568 (Don't use empty trait names) - rust-lang#139580 (Temporarily leave the review rotation) - rust-lang#139589 (saethlin is back from vacation) - rust-lang#139592 (rustdoc: Enable Markdown extensions when looking for doctests) - rust-lang#139599 (Tracking issue template: fine-grained information on style update status) - rust-lang#139600 (Update `compiler-builtins` to 0.1.153) - rust-lang#139606 (Update compiletest to Edition 2024) r? `@ghost` `@rustbot` modify labels: rollup

match ergonomics: replace `peel_off_references` with a recursive call This makes it imo quite a bit easier to follow how the binding mode gets calculated. cc ``@dianne``

Rollup of 17 pull requests Successful merges: - rust-lang#137412 (Ensure `swap_nonoverlapping` is really always untyped) - rust-lang#138167 (Small code improvement in rustdoc hidden stripper) - rust-lang#138605 (Clean up librustdoc::html::render to be better encapsulated) - rust-lang#138682 (Allow drivers to supply a list of extra symbols to intern) - rust-lang#138904 (Test linking and running `no_std` binaries) - rust-lang#139423 (Suppress missing field error when autoderef bottoms out in infer) - rust-lang#139449 (match ergonomics: replace `peel_off_references` with a recursive call) - rust-lang#139507 (compiletest: Trim whitespace from environment variable names) - rust-lang#139530 (Remove some dead or leftover code related to rustc-intrinsic abi removal) - rust-lang#139560 (fix title of offset_of_enum feature) - rust-lang#139563 (emit a better error message for using the macro incorrectly) - rust-lang#139568 (Don't use empty trait names) - rust-lang#139580 (Temporarily leave the review rotation) - rust-lang#139589 (saethlin is back from vacation) - rust-lang#139592 (rustdoc: Enable Markdown extensions when looking for doctests) - rust-lang#139599 (Tracking issue template: fine-grained information on style update status) - rust-lang#139600 (Update `compiler-builtins` to 0.1.153) r? `@ghost` `@rustbot` modify labels: rollup

…iaskrgr Rollup of 13 pull requests Successful merges: - rust-lang#138167 (Small code improvement in rustdoc hidden stripper) - rust-lang#138605 (Clean up librustdoc::html::render to be better encapsulated) - rust-lang#139423 (Suppress missing field error when autoderef bottoms out in infer) - rust-lang#139449 (match ergonomics: replace `peel_off_references` with a recursive call) - rust-lang#139507 (compiletest: Trim whitespace from environment variable names) - rust-lang#139530 (Remove some dead or leftover code related to rustc-intrinsic abi removal) - rust-lang#139560 (fix title of offset_of_enum feature) - rust-lang#139563 (emit a better error message for using the macro incorrectly) - rust-lang#139568 (Don't use empty trait names) - rust-lang#139580 (Temporarily leave the review rotation) - rust-lang#139589 (saethlin is back from vacation) - rust-lang#139592 (rustdoc: Enable Markdown extensions when looking for doctests) - rust-lang#139599 (Tracking issue template: fine-grained information on style update status) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#139449 - Nadrieril:peel-recursive, r=lcnr match ergonomics: replace `peel_off_references` with a recursive call This makes it imo quite a bit easier to follow how the binding mode gets calculated. cc ```@dianne```

rustbot assigned lcnr Apr 6, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 6, 2025

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 6, 2025

Nadrieril mentioned this pull request Apr 6, 2025

deref patterns: implement implicit deref patterns #138528

Open

This comment has been minimized.

Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 6, 2025

Nadrieril marked this pull request as ready for review April 6, 2025 18:41

lcnr reviewed Apr 8, 2025

View reviewed changes

compiler/rustc_hir_typeck/src/pat.rs Show resolved Hide resolved

lcnr reviewed Apr 8, 2025

View reviewed changes

compiler/rustc_hir_typeck/src/pat.rs Outdated Show resolved Hide resolved

Nadrieril added 6 commits April 8, 2025 23:26

Inline calc_default_binding_mode

a0d9c87

Insert adjustments incrementally

9f57903

Turn the peeling loop into a recursive call

19950b5

Reorganize check_pat_inner

38adb99

Return a type from check_pat_inner

6588018

Remove redundant assignment

f458151

Nadrieril force-pushed the peel-recursive branch from fb0d9f5 to f458151 Compare April 8, 2025 21:34

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 9, 2025

Zalathar mentioned this pull request Apr 10, 2025

Rollup of 18 pull requests #139612

Closed

Zalathar mentioned this pull request Apr 10, 2025

Rollup of 17 pull requests #139613

Closed

matthiaskrgr mentioned this pull request Apr 10, 2025

Rollup of 13 pull requests #139622

Merged

bors merged commit 7f08e63 into rust-lang:master Apr 10, 2025
6 checks passed

rustbot added this to the 1.88.0 milestone Apr 10, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

match ergonomics: replace `peel_off_references` with a recursive call #139449

match ergonomics: replace `peel_off_references` with a recursive call #139449

Nadrieril commented Apr 6, 2025

rustbot commented Apr 6, 2025

Nadrieril commented Apr 6, 2025

This comment has been minimized.

bors commented Apr 6, 2025

bors commented Apr 6, 2025

This comment has been minimized.

rust-timer commented Apr 6, 2025

Nadrieril commented Apr 6, 2025

lcnr commented Apr 8, 2025

lcnr commented Apr 9, 2025

bors commented Apr 9, 2025

match ergonomics: replace peel_off_references with a recursive call #139449

match ergonomics: replace peel_off_references with a recursive call #139449

Conversation

Nadrieril commented Apr 6, 2025

rustbot commented Apr 6, 2025

Nadrieril commented Apr 6, 2025

This comment has been minimized.

bors commented Apr 6, 2025

bors commented Apr 6, 2025

This comment has been minimized.

rust-timer commented Apr 6, 2025

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Nadrieril commented Apr 6, 2025

lcnr commented Apr 8, 2025

lcnr commented Apr 9, 2025

bors commented Apr 9, 2025

match ergonomics: replace `peel_off_references` with a recursive call #139449

match ergonomics: replace `peel_off_references` with a recursive call #139449