Rollup of 8 pull requests #140043
Merged
Rollup of 8 pull requests #140043
+2,813
−1,576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: onur-ozkan <[email protected]>
Signed-off-by: onur-ozkan <[email protected]>
Signed-off-by: onur-ozkan <[email protected]>
Signed-off-by: onur-ozkan <[email protected]>
Signed-off-by: onur-ozkan <[email protected]>
Signed-off-by: onur-ozkan <[email protected]>
Signed-off-by: onur-ozkan <[email protected]>
Signed-off-by: onur-ozkan <[email protected]>
Signed-off-by: onur-ozkan <[email protected]>
bors
added
the
S-waiting-on-review
|
seems spurious @bors retry couldn't create a temp dir: Access is denied |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 20, 2025
…enton Rollup of 8 pull requests Successful merges: - rust-lang#138934 (support config extensions) - rust-lang#139091 (Rewrite on_unimplemented format string parser.) - rust-lang#139753 (Make `#[naked]` an unsafe attribute) - rust-lang#139762 (Don't assemble non-env/bound candidates if projection is rigid) - rust-lang#139834 (Don't canonicalize crate paths) - rust-lang#139868 (Move `pal::env` to `std::sys::env_consts`) - rust-lang#139978 (Add citool command for generating a test dashboard) - rust-lang#139995 (Clean UI tests 4 of n) r? `@ghost` `@rustbot` modify labels: rollup
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
@bors retry network error |
bors
added
S-waiting-on-bors
|
⌛ Testing commit f0a0efd with merge 49e5e4e3a5610c240a717cb99003a5d5d3356679... |
|
☀️ Test successful - checks-actions |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 90fd16e (parent) -> 49e5e4e (this PR) Test differencesShow 83 test diffsStage 0
Stage 1
Stage 2
Additionally, 6 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboard\nRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 49e5e4e3a5610c240a717cb99003a5d5d3356679 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
|
📌 Perf builds for each rolled up PR:
previous master: 90fd16eb5b In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
|
Finished benchmarking commit (49e5e4e): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.
Max RSS (memory usage)Results (primary -0.5%, secondary 2.2%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (primary -0.5%, secondary -2.9%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 770.888s -> 773.64s (0.36%) |
ChrisDenton
added a commit
to ChrisDenton/rust
that referenced
this pull request
Apr 20, 2025
…eyouxu Remove stray newline from post-merge report [Oops](rust-lang#140043 (comment)) :) r? jieyouxu
ChrisDenton
added a commit
to ChrisDenton/rust
that referenced
this pull request
Apr 20, 2025
…eyouxu Remove stray newline from post-merge report [Oops](rust-lang#140043 (comment)) :) r? jieyouxu
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 20, 2025
Rollup merge of rust-lang#140063 - Kobzol:ci-report-fix-newline, r=jieyouxu Remove stray newline from post-merge report [Oops](rust-lang#140043 (comment)) :) r? jieyouxu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
#[naked]an unsafe attribute #139753 (Make#[naked]an unsafe attribute)pal::envtostd::sys::env_consts#139868 (Movepal::envtostd::sys::env_consts)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup