Skip to content

Conversation

jieyouxu
Copy link
Member

@jieyouxu jieyouxu commented May 17, 2025

Noticed in #140966 (comment). Seems like a broken label can cause the triagebot ping message to not be issued.

See rust-lang/triagebot#1992.

@rustbot label: +A-rust-for-linux

@rustbot
Copy link
Collaborator

rustbot commented May 17, 2025

r? @oli-obk

rustbot has assigned @oli-obk.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself A-rustc-dev-guide Area: rustc-dev-guide S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 17, 2025
@rustbot
Copy link
Collaborator

rustbot commented May 17, 2025

The rustc-dev-guide subtree was changed. If this PR only touches the dev guide consider submitting a PR directly to rust-lang/rustc-dev-guide otherwise thank you for updating the dev guide with your changes.

cc @BoxyUwU, @jieyouxu, @Kobzol

triagebot.toml has been modified, there may have been changes to the review queue.

cc @davidtwco, @wesleywiser

@Urgau
Copy link
Member

Urgau commented May 17, 2025

r? Urgau @bors r+ rollup

@bors
Copy link
Collaborator

bors commented May 17, 2025

📌 Commit 2dddbd1 has been approved by Urgau

It is now in the queue for this repository.

@rustbot rustbot assigned Urgau and unassigned oli-obk May 17, 2025
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 17, 2025
fmease added a commit to fmease/rust that referenced this pull request May 18, 2025
Fix Rust for Linux ping group label

Noticed in rust-lang#140966 (comment). Seems like a broken label can cause the triagebot ping message to not be issued.

See rust-lang/triagebot#1992.

`@rustbot` label: +A-rust-for-linux
fmease added a commit to fmease/rust that referenced this pull request May 18, 2025
Fix Rust for Linux ping group label

Noticed in rust-lang#140966 (comment). Seems like a broken label can cause the triagebot ping message to not be issued.

See rust-lang/triagebot#1992.

``@rustbot`` label: +A-rust-for-linux
bors added a commit to rust-lang-ci/rust that referenced this pull request May 18, 2025
Rollup of 7 pull requests

Successful merges:

 - rust-lang#140113 (Add per page TOC in the `rustc` book)
 - rust-lang#140490 (split `asm!` parsing and validation)
 - rust-lang#140924 (Make some `f32`/`f64` tests also run in const-context)
 - rust-lang#141045 ([win][arm64] Remove 'Arm64 Hazard' undocumented MSVC option and instead disable problematic test)
 - rust-lang#141071 (Enable [behind-upstream] triagebot option for rust-lang/rust)
 - rust-lang#141132 (Use `crate::` prefix for root macro suggestions)
 - rust-lang#141139 (Fix Rust for Linux ping group label)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request May 18, 2025
Rollup of 8 pull requests

Successful merges:

 - rust-lang#140113 (Add per page TOC in the `rustc` book)
 - rust-lang#140511 (Stabilize `#![feature(non_null_from_ref)]`)
 - rust-lang#140924 (Make some `f32`/`f64` tests also run in const-context)
 - rust-lang#140966 (Remove #![feature(let_chains)] from library and src/librustdoc)
 - rust-lang#141045 ([win][arm64] Remove 'Arm64 Hazard' undocumented MSVC option and instead disable problematic test)
 - rust-lang#141071 (Enable [behind-upstream] triagebot option for rust-lang/rust)
 - rust-lang#141132 (Use `crate::` prefix for root macro suggestions)
 - rust-lang#141139 (Fix Rust for Linux ping group label)

r? `@ghost`
`@rustbot` modify labels: rollup
@ojeda
Copy link
Contributor

ojeda commented May 18, 2025

Thanks for this!

@bors bors merged commit c7e2e88 into rust-lang:master May 18, 2025
6 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request May 18, 2025
Rollup merge of rust-lang#141139 - jieyouxu:fix-rfl, r=Urgau

Fix Rust for Linux ping group label

Noticed in rust-lang#140966 (comment). Seems like a broken label can cause the triagebot ping message to not be issued.

See rust-lang/triagebot#1992.

```@rustbot``` label: +A-rust-for-linux
@rustbot rustbot added this to the 1.89.0 milestone May 18, 2025
@jieyouxu jieyouxu deleted the fix-rfl branch May 19, 2025 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-meta Area: Issues & PRs about the rust-lang/rust repository itself A-rust-for-linux Relevant for the Rust-for-Linux project A-rustc-dev-guide Area: rustc-dev-guide S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants