Skip to content

Document why tidy checks if eslint is installed via npm #142877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 22, 2025
Merged

Document why tidy checks if eslint is installed via npm #142877

merged 1 commit into from
Jun 22, 2025

Conversation

yotamofek
Copy link
Contributor

@yotamofek yotamofek commented Jun 22, 2025 •
edited by rustbot
Loading

Discussion here: #142851

@rustbot
Copy link
Collaborator

rustbot commented Jun 22, 2025

r? @Kobzol

rustbot has assigned @Kobzol.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-tidy Area: The tidy tool S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jun 22, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jun 22, 2025

There are changes to the tidy tool.

cc @jieyouxu

@yotamofek
Copy link
Contributor Author

Woops, meant to r? @GuillaumeGomez , sorry for the noise!

@rustbot rustbot assigned GuillaumeGomez and unassigned Kobzol Jun 22, 2025
@GuillaumeGomez
Copy link
Member

Thanks!

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 22, 2025

📌 Commit 90524da has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 22, 2025
@GuillaumeGomez GuillaumeGomez mentioned this pull request Jun 22, 2025
Merged
bors added a commit that referenced this pull request Jun 22, 2025
@bors
Auto merge of #142878 - GuillaumeGomez:rollup-53dohob, r=GuillaumeGomez
111e9bc 
Rollup of 10 pull requests

Successful merges:

 - #142458 (Merge unboxed trait object error suggestion into regular dyn incompat error)
 - #142593 (Add a warning to LateContext::get_def_path)
 - #142594 (Add DesugaringKind::FormatLiteral)
 - #142740 (Clean-up `FnCtxt::is_destruct_assignment_desugaring`)
 - #142780 (Port `#[must_use]` to new attribute parsing infrastructure)
 - #142798 (Don't fail to parse a struct if a semicolon is used to separate fields)
 - #142856 (Add a few inline directives in rustc_serialize.)
 - #142868 (remove few allow(dead_code))
 - #142874 (cranelift: fix target feature name typo: "fxsr")
 - #142877 (Document why tidy checks if `eslint` is installed via `npm`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 8da1a62 into rust-lang:master Jun 22, 2025
10 checks passed
rust-timer added a commit that referenced this pull request Jun 22, 2025
@rust-timer
Unrolled build for #142877
37ed9b8 
Rollup merge of #142877 - yotamofek:pr/rustdoc/comment-eslint-installation-req, r=GuillaumeGomez

Document why tidy checks if `eslint` is installed via `npm`

Discussion here: #142851
@rustbot rustbot added this to the 1.89.0 milestone Jun 22, 2025
@yotamofek yotamofek deleted the pr/rustdoc/comment-eslint-installation-req branch June 28, 2025 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

Assignees

@GuillaumeGomez GuillaumeGomez

Labels
A-tidy Area: The tidy tool S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
1.89.0
Development

Successfully merging this pull request may close these issues.
5 participants
@yotamofek @rustbot @GuillaumeGomez @bors @Kobzol