Skip to content

Add ty_span query #143433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 8, 2025
Merged

Add ty_span query #143433

merged 1 commit into from
Jul 8, 2025
+67 −26

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Jul 4, 2025

r? @compiler-errors

fixes diagnostic regressions from #142030

Also uses the new query in check_const_item

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 4, 2025
@oli-obk
Copy link
Contributor Author

oli-obk commented Jul 4, 2025

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 4, 2025
bors added a commit that referenced this pull request Jul 4, 2025
@bors
Auto merge of #143433 - oli-obk:ty_span_qry, r=<try>
f2f6bec 
Add `ty_span` query

r? `@compiler-errors`

fixes diagnostic regressions from #142030

Also uses the new query in `check_const_item`
@bors
Copy link
Collaborator

bors commented Jul 4, 2025

⌛ Trying commit ccbaf66 with merge f2f6bec...

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Collaborator

bors commented Jul 4, 2025

☀️ Try build successful - checks-actions
Build commit: f2f6bec (f2f6bec11ae99d06d909fb84e7765638196d92d5)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (f2f6bec): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @rustbot label: +perf-regression-triaged. If not, please fix the regressions and do another perf run. If its results are neutral or positive, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)		 0.6% [0.3%, 0.9%] 9
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -1.0% [-1.0%, -1.0%] 2
All ❌✅ (primary) 0.6% [0.3%, 0.9%] 9

Max RSS (memory usage)

Results (primary -1.8%, secondary -1.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -1.8% [-1.8%, -1.7%] 2
Improvements ✅
(secondary)		 -1.5% [-2.1%, -0.8%] 2
All ❌✅ (primary) -1.8% [-1.8%, -1.7%] 2

Cycles

Results (primary 2.2%, secondary -0.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 2.2% [2.1%, 2.3%] 3
Regressions ❌
(secondary)		 3.4% [3.4%, 3.5%] 3
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -2.1% [-3.9%, -0.6%] 6
All ❌✅ (primary) 2.2% [2.1%, 2.3%] 3

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 461.146s -> 461.095s (-0.01%)
Artifact size: 372.20 MiB -> 372.34 MiB (0.04%)

@rustbot rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Jul 4, 2025
@compiler-errors
Copy link
Member

r=me

@oli-obk
Copy link
Contributor Author

oli-obk commented Jul 7, 2025

@bors r=compiler-errors

@bors
Copy link
Collaborator

bors commented Jul 7, 2025

📌 Commit 62929b9 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 7, 2025
@bors
Copy link
Collaborator

bors commented Jul 8, 2025

⌛ Testing commit 62929b9 with merge 688ea65...

@bors
Copy link
Collaborator

bors commented Jul 8, 2025

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing 688ea65 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 8, 2025
@bors bors merged commit 688ea65 into rust-lang:master Jul 8, 2025
12 checks passed
@rustbot rustbot added this to the 1.90.0 milestone Jul 8, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 8, 2025

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing a2d45f7 (parent) -> 688ea65 (this PR)

Test differences

Show 30 test diffs

30 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 688ea65df6a47866d0f72a00f1e18b47a7edf83b --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-aarch64-linux: 5487.6s -> 8291.7s (51.1%)
  2. dist-x86_64-apple: 8110.9s -> 11205.1s (38.1%)
  3. x86_64-apple-2: 6584.6s -> 4229.6s (-35.8%)
  4. x86_64-apple-1: 10550.7s -> 8284.3s (-21.5%)
  5. pr-check-1: 1615.6s -> 1827.9s (13.1%)
  6. aarch64-apple: 5258.2s -> 4727.3s (-10.1%)
  7. dist-armhf-linux: 5168.0s -> 4775.7s (-7.6%)
  8. aarch64-gnu-debug: 3843.4s -> 4115.7s (7.1%)
  9. aarch64-gnu: 6996.4s -> 6539.2s (-6.5%)
  10. x86_64-msvc-2: 6526.7s -> 6921.5s (6.0%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (688ea65): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

  • If the regression was expected or you think it can be justified,
    please write a comment with sufficient written justification, and add
    @rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
  • If you think that you know of a way to resolve the regression, try to create
    a new PR with a fix for the regression.
  • If you do not understand the regression or you think that it is just noise,
    you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
    were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)		 0.6% [0.2%, 0.9%] 11
Regressions ❌
(secondary)		 0.1% [0.0%, 0.2%] 2
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -0.2% [-0.3%, -0.1%] 2
All ❌✅ (primary) 0.6% [0.2%, 0.9%] 11

Max RSS (memory usage)

Results (primary -2.1%, secondary -2.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -2.1% [-2.2%, -2.0%] 3
Improvements ✅
(secondary)		 -2.0% [-2.6%, -1.2%] 4
All ❌✅ (primary) -2.1% [-2.2%, -2.0%] 3

Cycles

Results (secondary 1.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 3.1% [2.1%, 4.0%] 4
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -2.8% [-4.0%, -1.6%] 2
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 465.163s -> 465.817s (0.14%)
Artifact size: 372.20 MiB -> 372.34 MiB (0.04%)

@oli-obk oli-obk deleted the ty_span_qry branch July 8, 2025 04:47
@oli-obk
Copy link
Contributor Author

oli-obk commented Jul 8, 2025

The regression is expected: libc has a million items that now each have a new dep node and corresponding dep graph edges

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@compiler-errors compiler-errors

Labels
merged-by-bors This PR was explicitly merged by bors. perf-regression Performance regression. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.90.0
Development

Successfully merging this pull request may close these issues.
6 participants
@oli-obk @rust-timer @bors @rust-log-analyzer @compiler-errors @rustbot