Port #[automatically_derived] to the new attribute parsing infrastructure
#143779
+92
−50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ucture Signed-off-by: Jonathan Brouwer <[email protected]>
rustbot
added
A-attributes
|
Some changes occurred in compiler/rustc_passes/src/check_attr.rs Some changes occurred in compiler/rustc_attr_parsing Some changes occurred in src/tools/clippy cc @rust-lang/clippy Some changes occurred in compiler/rustc_attr_data_structures Some changes occurred in match checking cc @Nadrieril |
JonathanBrouwer
commented
Jul 11, 2025
| @@ -1304,6 +1304,7 @@ impl AttributeExt for Attribute { | |||
| Attribute::Parsed(AttributeKind::DocComment { span, .. }) => *span, | |||
| Attribute::Parsed(AttributeKind::MayDangle(span)) => *span, | |||
| Attribute::Parsed(AttributeKind::Ignore { span, .. }) => *span, | |||
| Attribute::Parsed(AttributeKind::AutomaticallyDerived(span)) => *span, | |||
There was a problem hiding this comment.
This change is needed to fix #143780 for automatically_derived. automatically_derived is part of a test case so this is necessary to add now. @jdonszelmann and I are discussing a general solution to this problem.
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Jonathan Brouwer <[email protected]>
Signed-off-by: Jonathan Brouwer <[email protected]>
JonathanBrouwer
force-pushed
the
automatically_derived_parser
branch
from
8ffd1bf to
499af0e
Compare
|
There are lots of these attributes produced by built-in derives, let's do a perf. run once this is ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports
#[automatically_derived]to the new attribute parsing infrastructure for #131229 (comment)r? @oli-obk
cc @jdonszelmann