Skip to content

Fix ICE for parsed attributes with longer path not handled by CheckAttribute #143796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix ICE for parsed attributes with longer path not handled by CheckAttribute #143796

wants to merge 1 commit into from
+40 −1

Conversation

JonathanBrouwer
Copy link
Contributor

Fixes #137590
Fixes #143789

r? @jdonszelmann

@rustbot
Copy link
Collaborator

rustbot commented Jul 11, 2025

jdonszelmann is currently at their maximum review capacity.
They may take a while to respond.

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 11, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jul 11, 2025

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

@JonathanBrouwer JonathanBrouwer changed the title Fix ICE for parsed attributes with longer path not handled by CheckAt… Fix ICE for parsed attributes with longer path not handled by CheckAttribute Jul 11, 2025
@jdonszelmann
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jul 11, 2025

📌 Commit 2f05fa6 has been approved by jdonszelmann

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 11, 2025
@JonathanBrouwer JonathanBrouwer mentioned this pull request Jul 11, 2025
Open
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 12, 2025
@matthiaskrgr
Rollup merge of rust-lang#143796 - JonathanBrouwer:fix-builtin-attrib…
04bf6fb 
…ute-prefix, r=jdonszelmann

Fix ICE for parsed attributes with longer path not handled by CheckAttribute

Fixes rust-lang#137590
Fixes rust-lang#143789

r? `@jdonszelmann`
@matthiaskrgr matthiaskrgr mentioned this pull request Jul 12, 2025
Open
@JonathanBrouwer JonathanBrouwer mentioned this pull request Jul 12, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdonszelmann jdonszelmann

Labels
A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
4 participants
@JonathanBrouwer @rustbot @jdonszelmann @bors