Skip to content

Rehome 35 tests/ui/issues/ tests to other subdirectories under tests/ui/ #144089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Rehome 35 tests/ui/issues/ tests to other subdirectories under tests/ui/ #144089

wants to merge 1 commit into from

Conversation

Oneirical
Copy link
Contributor

@Oneirical Oneirical commented Jul 17, 2025 •
edited by rustbot
Loading

#143902 divided into smaller, easier to review chunks.

Part of #133895

Methodology:

  1. Refer to the previously written tests/ui/SUMMARY.md
  2. Find an appropriate category for the test, using the original issue thread and the test contents.
  3. Add the issue URL at the bottom (not at the top, as that would mess up stderr line numbers)
  4. Rename the tests to make their purpose clearer

The URL addition at the end, as well as moving around the auxiliary files and editing the stderr files with the new filename, were done using a Python script.

Inspired by the methodology that @Kivooeo was using.

r? @jieyouxu

@rustbot
Copy link
Collaborator

rustbot commented Jul 17, 2025

jieyouxu is not on the review rotation at the moment.
They may take a while to respond.

@rustbot rustbot added A-tidy Area: The tidy tool S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 17, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jul 17, 2025

There are changes to the tidy tool.

cc @jieyouxu

@Oneirical Oneirical force-pushed the uncountable-integer-1 branch from 74fe4ca to a62b29d Compare July 17, 2025 21:47
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Collaborator

bors commented Jul 19, 2025

☔ The latest upstream changes (presumably #144145) made this pull request unmergeable. Please resolve the merge conflicts.

@Oneirical Oneirical force-pushed the uncountable-integer-1 branch from a62b29d to 2cfcf5d Compare July 19, 2025 20:19
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Oneirical Oneirical force-pushed the uncountable-integer-1 branch from 2cfcf5d to f63de22 Compare July 19, 2025 21:30
@jieyouxu jieyouxu closed this Jul 21, 2025
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 21, 2025
@jieyouxu jieyouxu reopened this Jul 21, 2025
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 21, 2025
@jieyouxu
Copy link
Member

I'm going to review the PR removing the issue limits check first, as otherwise this and Kivo's other PR moving issues/ tests will merge conflict.

jieyouxu
jieyouxu requested changes Jul 22, 2025
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. A few nits

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 22, 2025
@Oneirical Oneirical force-pushed the uncountable-integer-1 branch from f63de22 to 06227df Compare July 23, 2025 01:32
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Oneirical Oneirical force-pushed the uncountable-integer-1 branch from 06227df to c66a895 Compare July 23, 2025 02:45
@bors
Copy link
Collaborator

bors commented Jul 23, 2025

☔ The latest upstream changes (presumably #144360) made this pull request unmergeable. Please resolve the merge conflicts.

@Oneirical Oneirical force-pushed the uncountable-integer-1 branch from c66a895 to a924d44 Compare July 24, 2025 21:01
@rustbot
Copy link
Collaborator

rustbot commented Jul 24, 2025

This PR modifies tests/ui/issues/. If this PR is adding new tests to tests/ui/issues/,
please refrain from doing so, and instead add it to more descriptive subdirectories.

@Oneirical
Copy link
Contributor Author

@rustbot ready

@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jul 24, 2025
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 24, 2025
jieyouxu
jieyouxu approved these changes Jul 25, 2025
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

tests/ui/cast/trait-object-cast-segfault-4333.rs
@@ -7,3 +7,5 @@ pub fn main() {
let stdout = &mut io::stdout() as &mut dyn io::Write;
stdout.write(b"Hello!");
}

// https://github.com/rust-lang/rust/issues/4333
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remark: hm, I think I would still prefer having these comments at the top of the test, and keep two commits {move, edits}. It's fine for this PR, but I do still think it's nicer to have the doc comments / backlinks on start of file.

@jieyouxu
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jul 25, 2025

📌 Commit a924d44 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 25, 2025
@jieyouxu jieyouxu removed T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) A-tidy Area: The tidy tool labels Jul 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@jieyouxu jieyouxu

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Oneirical @rustbot @rust-log-analyzer @bors @jieyouxu