tests: debuginfo: Disable broken tests on powerpc #144160
Open
+14
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-compiletest
|
Some changes occurred in src/tools/compiletest cc @jieyouxu |
This comment has been minimized.
This comment has been minimized.
f16 support for PowerPC has issues in LLVM, therefore we need to disable the tests that make use of f16. It also appears that unused by-value non-immedate issue with gdb applies to PowerPC targets as well, though I've only tested 64-bit Linux targets. Signed-off-by: Jens Reidel <[email protected]>
Gelbpunkt
force-pushed
the
debuginfo-tests-ppc
branch
from
f90a6c1 to
9ce00f5
Compare
Comment on lines
+3
to
+7
| // Targets with broken f16 cannot link due to missing __gnu_f2h_ieee | ||
| // See https://github.com/llvm/llvm-project/issues/97981 | ||
| // and https://github.com/rust-lang/compiler-builtins/issues/655 | ||
| //@ ignore-powerpc | ||
| //@ ignore-powerpc64 |
There was a problem hiding this comment.
I feel that we really should not have types that must be ignored in the same file as other types.
There was a problem hiding this comment.
So would you suggest splitting off the f16 parts into a f16-globals-metadata test and disabling that on the affected targets?
There was a problem hiding this comment.
Yes, I think that would be preferable. If it's powerpc, then it's likely going to be others.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
f16 support for PowerPC has issues in LLVM, therefore we need to disable the tests that make use of f16.
It also appears that #128973 applies to PowerPC targets as well, though I've only tested 64-bit Linux targets.