Rollup of 5 pull requests

[jieyouxu]

Successful merges:

• Tidy cleanup 2 #143960 (Tidy cleanup 2)
• docs: update link to RISC-V and Xtensa installation guide #144149 (docs: update link to RISC-V and Xtensa installation guide)
• Rename optional-mingw-check-1 to optional-pr-check-1 #144152 (Rename optional-mingw-check-1 to optional-pr-check-1)
• Fix clippy lints in librustdoc #144178 (Fix clippy lints in librustdoc)
• fix load-bearing typo #144180 (fix load-bearing typo)

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

[jieyouxu]

Tiny rollup to include #144180 to unbrick PR CI. See #t-infra > Spellcheck workflow now fails on all PRs (tree bad?).

@bors r+ rollup=never p=10 (PR CI spellcheck failure)

[bors]

📌 Commit a8daf4c has been approved by jieyouxu

It is now in the queue for this repository.

[bors]

⌛ Testing commit a8daf4c with merge 1d30b9d...

[lqd]

there's a p-critical fix in the queue at p=6, we shouldn't make rollups at p>5 without rolling up the other important PRs

[jieyouxu]

Given that this is still quite early, we can yield to to the P-critical. Also I thought the spellcheck was blocking, but it wasn't so...

@bors p=5
@bors retry (yielding to P-critical fix)

[lqd]

There likely was still time to get both in, but why not :)

[lqd]

but yeah it'd be cutting it close, it may even be close now, with CI now taking 3+ hours; good call

[bors]

⌛ Testing commit a8daf4c with merge ee3a078...

[bors]

☀️ Test successful - checks-actions
Approved by: jieyouxu
Pushing ee3a078 to master...

[rust-timer]

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#143960	Tidy cleanup 2	445be5bcb3a2273338b747363b11be1f6f88ff5b (link)
#144149	docs: update link to RISC-V and Xtensa installation guide	6af98966419fe460076d40f9bba62461871fe235 (link)
#144152	Rename optional-mingw-check-1 to optional-pr-check-1	a176e5c77841bc3d41bec4f5a6cabc7737b11e1c (link)
#144178	Fix clippy lints in librustdoc	1e20e38b124f2a1eab959455a91d8a4e9602a63e (link)
#144180	fix load-bearing typo	a8a4c40acc4bcb73ce9f362f9e76704bd48c556d (link)

previous master: 0d95920262

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

[github-actions]

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 0d95920 (parent) -> ee3a078 (this PR)

Test differences

Show 4 test diffs

4 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard ee3a0783df39cb11c5706e38805eb9258b4fad79 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

1. x86_64-apple-2: 4746.0s -> 3681.7s (-22.4%)
2. x86_64-apple-1: 10393.0s -> 8162.5s (-21.5%)
3. dist-x86_64-apple: 11155.4s -> 9178.8s (-17.7%)
4. dist-apple-various: 7083.9s -> 6246.5s (-11.8%)
5. aarch64-gnu: 6740.1s -> 6231.6s (-7.5%)
6. dist-s390x-linux: 4814.4s -> 5139.3s (6.7%)
7. dist-i586-gnu-i586-i686-musl: 5437.0s -> 5707.0s (5.0%)
8. aarch64-msvc-2: 5482.1s -> 5241.2s (-4.4%)
9. x86_64-msvc-ext2: 5558.8s -> 5351.1s (-3.7%)
10. dist-powerpc-linux: 4798.8s -> 4968.4s (3.5%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

[rust-timer]

Finished benchmarking commit (ee3a078): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.2%	[-0.3%, -0.1%]	3
Improvements ✅ (secondary)	-0.5%	[-0.9%, -0.2%]	7
All ❌✅ (primary)	-0.2%	[-0.3%, -0.1%]	3

Max RSS (memory usage)

Results (primary -2.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.7%	[-3.5%, -2.1%]	3
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-2.7%	[-3.5%, -2.1%]	3

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 465.968s -> 464.521s (-0.31%)
Artifact size: 374.57 MiB -> 374.65 MiB (0.02%)