Add --print target-spec-json-schema #144498

Noratrieb · 2025-07-26T10:42:53Z

This schema is helpful for people writing custom target spec JSON. It can provide autocomplete in the editor, and also serves as documentation when there are documentation comments on the structs, as schemars will put them in the schema.

I was motivated to do this because I saw someone write their own version of this schema by hand, so demand for this clearly exists. It's not a lot of effort to implement, so I thought it would make sense.

MCP: rust-lang/compiler-team#905

I think it would also be useful to put this in the sysroot in etc so people can link it directly in their editors.

I would have loved to add a test that validates the JSON schema against the spec JSON of every builtin target, but I don't want to do it as the JSON schema validation crates have incredible amounts of dependencies because JSON schema supports a ton of random features. I don't want to add that, even as a dev dependency.

compiler/rustc_target/src/lib.rs

rustbot · 2025-07-27T17:53:01Z

r? @fee1-dead

rustbot has assigned @fee1-dead.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot · 2025-07-27T17:53:03Z

Some changes occurred in compiler/rustc_codegen_ssa

cc @WaffleLapkin

The list of allowed third-party dependencies may have been modified! You must ensure that any new dependencies have compatible licenses before merging.

cc @davidtwco, @wesleywiser

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

These commits modify compiler targets.
(See the Target Tier Policy.)

This PR modifies run-make tests.

cc @jieyouxu

There are changes to the tidy tool.

cc @jieyouxu

Noratrieb · 2025-07-27T17:53:28Z

The MCP isn't accepted yet, but that doesn't need to stop anyone from reviewing.
r? jieyouxu maybe you want to review it since it also touches bootstrap?

rustbot · 2025-07-27T17:53:32Z

jieyouxu is currently at their maximum review capacity.
They may take a while to respond.

jieyouxu · 2025-07-28T05:40:49Z

I can probably review it after the MCP passes.

jieyouxu

Thanks, looks good to me overall, a few questions

compiler/rustc_target/src/spec/mod.rs

jieyouxu · 2025-07-29T04:02:55Z

src/tools/tidy/src/deps.rs

@@ -361,6 +362,8 @@ const PERMITTED_RUSTC_DEPENDENCIES: &[&str] = &[
    "rand_xorshift", // dependency for doc-tests in rustc_thread_pool
    "rand_xoshiro",
    "redox_syscall",
+    "ref-cast",


Remark: at least this uses rustc version detection, not just nightly detection

https://github.com/dtolnay/ref-cast/blob/1.0.24/build.rs

jieyouxu · 2025-07-29T04:07:43Z

None of them are blocking, so feel free to r=me once the MCP is accepted.

rust-bors · 2025-08-11T20:04:47Z

☀️ Try build successful (CI)
Build commit: 2bfac14 (2bfac149c1d597d832231f56dadf7c09ef3195f8, parent: fce0e74720d199eb7839fdb51af35ac5226da178)

davidtwco

Licenses of the new dependencies are good

jieyouxu

Thanks, impl looks good too, r=me as well after fixing the lint problem

bors · 2025-08-21T11:11:54Z

☔ The latest upstream changes (presumably #145701) made this pull request unmergeable. Please resolve the merge conflicts.

With this macro we only need to enumerate every variant once. This saves a lot of duplication already between the definition, the `FromStr` impl and the `ToJson` impl. It also enables us to do further things with it like JSON schema generation.

This schema is helpful for people writing custom target spec JSON. It can provide autocomplete in the editor, and also serves as documentation when there are documentation comments on the structs, as `schemars` will put them in the schema.

rustbot · 2025-09-12T18:54:11Z

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

Noratrieb · 2025-09-12T20:26:47Z

@rustbot ready
I finally managed to rebase, the range-diff is a bit confusing but it should work fine.

jieyouxu

Thanks

View changes since this review

jieyouxu · 2025-09-13T04:39:15Z

@bors r=jieyouxu,davidtwco

bors · 2025-09-13T04:39:18Z

📌 Commit f157ce9 has been approved by jieyouxu,davidtwco

It is now in the queue for this repository.

Rollup of 5 pull requests Successful merges: - #144498 (Add --print target-spec-json-schema) - #145471 (Stabilize BTree{Map,Set}::extract_if) - #145896 (Rehome 30 `tests/ui/issues/` tests to other subdirectories under `tests/ui/` [#3 of Batch #2]) - #146450 (bootstrap: rustdoc-js tests can now be filtered by js files) - #146456 (Fix panic and incorrectly suggested examples in `format_args` macro.) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #144498 - Noratrieb:rustc-json-schema, r=jieyouxu,davidtwco Add --print target-spec-json-schema This schema is helpful for people writing custom target spec JSON. It can provide autocomplete in the editor, and also serves as documentation when there are documentation comments on the structs, as `schemars` will put them in the schema. I was motivated to do this because I saw someone write their own version of this schema by hand, so demand for this clearly exists. It's not a lot of effort to implement, so I thought it would make sense. MCP: rust-lang/compiler-team#905 I think it would also be useful to put this in the sysroot in `etc` so people can link it directly in their editors. I would have loved to add a test that validates the JSON schema against the spec JSON of every builtin target, but I don't want to do it as the JSON schema validation crates have incredible amounts of dependencies because JSON schema supports a ton of random features. I don't want to add that, even as a dev dependency.

Rollup of 5 pull requests Successful merges: - rust-lang/rust#144498 (Add --print target-spec-json-schema) - rust-lang/rust#145471 (Stabilize BTree{Map,Set}::extract_if) - rust-lang/rust#145896 (Rehome 30 `tests/ui/issues/` tests to other subdirectories under `tests/ui/` [rust-lang/rust#3 of Batch rust-lang/rust#2]) - rust-lang/rust#146450 (bootstrap: rustdoc-js tests can now be filtered by js files) - rust-lang/rust#146456 (Fix panic and incorrectly suggested examples in `format_args` macro.) r? `@ghost` `@rustbot` modify labels: rollup

See: <rust-lang/rust#144498>

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 26, 2025

This comment has been minimized.

Sign in to view

Noratrieb mentioned this pull request Jul 26, 2025

Add JSON schema for target spec JSON rust-lang/compiler-team#905

Closed

3 tasks

Noratrieb commented Jul 26, 2025

View reviewed changes

compiler/rustc_target/src/lib.rs Outdated Show resolved Hide resolved

Noratrieb force-pushed the rustc-json-schema branch from 547cba8 to d6acb28 Compare July 26, 2025 22:15

rustbot added A-tidy Area: The tidy tool T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jul 26, 2025

This comment has been minimized.

Sign in to view

Noratrieb force-pushed the rustc-json-schema branch from d6acb28 to 8f1abd3 Compare July 27, 2025 11:33

This comment has been minimized.

Sign in to view

Noratrieb force-pushed the rustc-json-schema branch from 8f1abd3 to a07cfd1 Compare July 27, 2025 12:18

This comment has been minimized.

Sign in to view

Noratrieb force-pushed the rustc-json-schema branch from a07cfd1 to d4383c1 Compare July 27, 2025 13:42

rustbot added the A-run-make Area: port run-make Makefiles to rmake.rs label Jul 27, 2025

Noratrieb marked this pull request as ready for review July 27, 2025 17:52

rustbot assigned fee1-dead Jul 27, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 27, 2025

rustbot assigned jieyouxu and unassigned fee1-dead Jul 27, 2025

jieyouxu approved these changes Jul 29, 2025

View reviewed changes

jieyouxu added S-waiting-on-MCP Status: PR has a compiler MCP and is waiting for the compiler MCP to complete. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 29, 2025

This comment has been minimized.

Sign in to view

davidtwco reviewed Aug 13, 2025

View reviewed changes

jieyouxu approved these changes Aug 14, 2025

View reviewed changes

jieyouxu removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 14, 2025

Noratrieb force-pushed the rustc-json-schema branch from e7009c1 to 87a9a91 Compare August 20, 2025 17:01

Noratrieb added 2 commits September 12, 2025 20:37

Add --print target-spec-json-schema

f157ce9

This schema is helpful for people writing custom target spec JSON. It can provide autocomplete in the editor, and also serves as documentation when there are documentation comments on the structs, as `schemars` will put them in the schema.

Noratrieb force-pushed the rustc-json-schema branch from 87a9a91 to f157ce9 Compare September 12, 2025 18:54

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 12, 2025

jieyouxu approved these changes Sep 13, 2025

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 13, 2025

jhpratt mentioned this pull request Sep 13, 2025

Rollup of 5 pull requests #146499

Merged

bors merged commit 5446444 into rust-lang:master Sep 13, 2025
10 checks passed

rustbot added this to the 1.91.0 milestone Sep 13, 2025

tennox mentioned this pull request Sep 14, 2025

Error building rustc for x86_64-unknown-linux-gnu using selectLatestNightlyWith oxalica/rust-overlay#233

Closed

oxalica added a commit to oxalica/rust-overlay that referenced this pull request Sep 15, 2025

mk-component-set: fix nightly build failure on non-empty /etc.

4232f52

See: <rust-lang/rust#144498>

oxalica mentioned this pull request Sep 15, 2025

Fix nightly and WASI example build failure oxalica/rust-overlay#234

Merged

oxalica added a commit to oxalica/rust-overlay that referenced this pull request Sep 15, 2025

mk-component-set: fix nightly build failure on non-empty /etc.

66792ee

See: <rust-lang/rust#144498>

github-actions bot mentioned this pull request Sep 12, 2025

Toolchain upgrade to nightly-2025-09-16 flux-rs/flux#1271

Draft

Add --print target-spec-json-schema #144498

Add --print target-spec-json-schema #144498

Uh oh!

Conversation

Noratrieb commented Jul 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rustbot commented Jul 27, 2025

Uh oh!

rustbot commented Jul 27, 2025

Uh oh!

Noratrieb commented Jul 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jul 27, 2025

Uh oh!

jieyouxu commented Jul 28, 2025

Uh oh!

jieyouxu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

jieyouxu Jul 29, 2025

Choose a reason for hiding this comment

Uh oh!

jieyouxu commented Jul 29, 2025

Uh oh!

This comment has been minimized.

rust-bors bot commented Aug 11, 2025

Uh oh!

davidtwco left a comment

Choose a reason for hiding this comment

Uh oh!

jieyouxu left a comment

Choose a reason for hiding this comment

Uh oh!

bors commented Aug 21, 2025

Uh oh!

rustbot commented Sep 12, 2025

Uh oh!

Noratrieb commented Sep 12, 2025

Uh oh!

jieyouxu left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jieyouxu commented Sep 13, 2025

Uh oh!

bors commented Sep 13, 2025

Uh oh!

Uh oh!

Uh oh!

Noratrieb commented Jul 26, 2025 •

edited

Loading

Noratrieb commented Jul 27, 2025 •

edited

Loading

jieyouxu left a comment •

edited by rustbot

Loading