Skip to content

Conversation

Dylan-DPC-zz
Copy link

Successful merges:

Failed merges:

r? @ghost

lcnr and others added 11 commits April 29, 2020 19:29
- Documented rationale of current solution
- Polished documentation
I believe that this is a copy/paste error; this example was using f32,
but it's the docs for f64.
…pnkfelix

forbid `dyn Trait` in patterns

Do not allow `&dyn Trait` as a generic const parameters.
This also changes dyn trait in pattern from ICE to error.

closes rust-lang#63322
closes rust-lang#70972

r? @eddyb
…wesleywiser

Added MIR constant propagation of Scalars into function call arguments

Now for the function call arguments!

Caveats:
1. It's only being enabled at `mir-opt-2` or higher, because currently codegen gives performance regressions with this optimization.
2. Only propagates Scalars. Tuples and references (references are `Indirect`, right??) are not being propagated into as of this PR.
3. Maybe more tests would be nice?
4. I need (shamefully) to ask @wesleywiser to write in his words (or explain to me, and then I can write it down) why we want to ignore propagation into `ScalarPairs` and `Indirect` arguments.

r? @wesleywiser
Do not try to find binop method on RHS `TyErr`

Fix rust-lang#71798.
…ark-Simulacrum

Use f64 in f64 examples

I believe that this is a copy/paste error; this example was using f32,
but it's the docs for f64.
@Dylan-DPC-zz
Copy link
Author

@bors r+ rollup=never p=5

@bors
Copy link
Collaborator

bors commented May 4, 2020

📌 Commit fc2837b has been approved by Dylan-DPC

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label May 4, 2020
@bors
Copy link
Collaborator

bors commented May 4, 2020

⌛ Testing commit fc2837b with merge 2454a68...

@bors
Copy link
Collaborator

bors commented May 4, 2020

☀️ Test successful - checks-azure
Approved by: Dylan-DPC
Pushing 2454a68 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 4, 2020
@bors bors merged commit 2454a68 into rust-lang:master May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants