Add overview.drawio.svg #1725
Open
Add overview.drawio.svg #1725
+342,257
−108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Yuki Okushi <[email protected]>
As implemented in rust-lang/rust#103345
* Update `traits/resolution.md` Co-authored by: @lcnr and @spastorino * Update src/traits/resolution.md * Wrapping * Update src/traits/resolution.md Co-authored-by: Santiago Pastorino <[email protected]> Co-authored-by: Santiago Pastorino <[email protected]>
According to rust-lang/rust@8873e33 > Running with --bless causes the push to succeed if there are fixable formatting changes, but the changes don't make it into the push. > > We should have the user rerun with --bless (or x.py fmt) and commit the changes themselves (they might want to amend a particular commit, for instance).
Updated Diagnostic text to use the same language used in Subdiagnostic
* Fix some typos. Co-authored-by: pierwill <[email protected]>
- queries always need a description - `QueryDescription` isn't just for descriptions (it's actually not for descriptions at all now) and always implemented by the macro - queries are not grouped into categories
Co-authored-by: Tshepang Mbambo <[email protected]>
Co-authored-by: Yuki Okushi <[email protected]>
rust-lang/project-const-generics#21 removed the link. This replaces it with an issue link mentioned on the design docs. Signed-off-by: Yuki Okushi <[email protected]>
Updates the location of the `try_mark_green` algorithm from `compiler/rustc_middle/src/dep_graph/graph.rs` to [`compiler/rustc_middle/src/dep_graph/graph.rs`](https://github.com/rust-lang/rust/blob/stable/compiler/rustc_query_system/src/dep_graph/graph.rs#L574) .
Co-authored-by: Noah Lev <[email protected]>
`-C incremental` is sound and --keep-stage is not.
Co-authored-by: Noah Lev <[email protected]>
I'm going to make a follow-up PR shortly linking from rust-lang/rust to the dev guide so this info isn't duplicated.
Co-authored-by: Yuki Okushi <[email protected]>
|
I think it's better to convert this file to something like ref: |
|
Cool, first time knowing that, thanks :-) |
jieyouxu
added
the
S-waiting-on-review
5 tasks
jieyouxu
added
T-compiler
|
Sorry, due to me messing up a git operation, we sadly had to force-push the whole commit history of rustc-dev-guide :( If you'd like to update this pull request, you will have to rebase it in a special way onto the new commit history (the new More context can be found here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
draw.io: https://www.drawio.com/
I used to do some notes using these kind of files, they are easy to use and their size is affordable. Since I haven't seen such graphs about the rustc, I did this myself hoping it could be a help for anyone who wants to get to know the arch of the rustc and its workflow.
Currently I've just placed it in
src/drawio/overview.drawioas I think this might be a good place to store such kind of files.You can edit
*.drawioby VSCode extension or online:I'm new to rustc so the
overview.drawiomight not be entirely correct, and I wish that someone could fix it or add more info about the rustc :-)