Skip to content

Fix profiling with samply. #2222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 19, 2025
Merged

Fix profiling with samply. #2222

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions collector/src/compile/execute/profiler.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,11 +250,13 @@ impl Processor for ProfileProcessor<'_> {
}

// Samply produces (via rustc-fake) a data file called
// `profile.json`. We copy it from the temp dir to the output dir,
// giving it a new name in the process.
// `profile.json.gz`. We copy it from the temp dir to the output dir,
// giving it a new name in the process. The new name must end
// in `.gz` for `samply load` to handle it.
Profiler::Samply => {
let tmp_samply_file = filepath(data.cwd, "profile.json");
let samply_file = filepath(self.output_dir, &out_file("samply"));
let tmp_samply_file = filepath(data.cwd, "profile.json.gz");
let samply_file =
filepath(self.output_dir, &format!("{}.gz", out_file("samply")));

fs::copy(tmp_samply_file, samply_file)?;
}
Expand Down
Loading