Store codegen backend and target into self-profile URL#2376
Merged
Kobzol merged 5 commits intorust-lang:masterfrom Jan 29, 2026
Merged
Store codegen backend and target into self-profile URL#2376Kobzol merged 5 commits intorust-lang:masterfrom
Kobzol merged 5 commits intorust-lang:masterfrom
Conversation
…ifact ID and without collection ID and artifact row ID number
Kobzol
force-pushed
the
self-profile-id-rework
branch
from
adb17c6 to
31d7c04
Compare
Jamesbarford
approved these changes
Jan 29, 2026
Member
Author
|
Let's try! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR creates a new URL encoding for self-profile files, which respects the used codegen backend and target. Running benchmarks with a non-standard codegen backend and target will thus no longer "brick" both the benchmarked commit and its parent.
To maintain some compatibility with old self-profile links, we still try to check if we have legacy self-profile data entries in the DB, and if yes, try to load from the legacy URL. This is not enabled for compilation sections though, I don't think it would be worth the effort.