Skip to content

fix - check for artifacts existance before downloading#2377

Merged
Kobzol merged 2 commits intorust-lang:masterfrom
Jamesbarford:fix/check-artifact-exists-before-db-insert
Feb 2, 2026
Merged

fix - check for artifacts existance before downloading#2377
Kobzol merged 2 commits intorust-lang:masterfrom
Jamesbarford:fix/check-artifact-exists-before-db-insert

Conversation

@Jamesbarford
Copy link
Contributor

This does not presently reuse Component, open to suggestions as to where it should live so we can reuse it if needed.

@Jamesbarford Jamesbarford requested a review from Kobzol February 2, 2026 09:51
Copy link
Member

@Kobzol Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one nit, other than that looks good. I think we might want to ignore transient errors and just let the artifact through, but we can start with the more strict variant and we'll see what happens in production.

@Kobzol Kobzol added this pull request to the merge queue Feb 2, 2026
Merged via the queue into rust-lang:master with commit 1f12e22 Feb 2, 2026
14 checks passed
@Jamesbarford Jamesbarford deleted the fix/check-artifact-exists-before-db-insert branch February 2, 2026 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants