Fix Cachegrind diff output file names.#2383
Merged
Kobzol merged 1 commit intorust-lang:masterfrom Feb 5, 2026
Merged
Conversation
When you run a Cachegrind diff via `profile_local` it produces a mix of `cgout` files (raw output) and `cgann` files (processed output). A couple of the files have `cgout` prefixes when they should have `cgann` prefixes, e.g.: ``` cgout-diff-794495e2b4a1353cf7b66ffc55f0e755490af2cc-540561de691be003ef1a9f9bf263df00e951622f-tuple-stress-Check-IncrUnchanged cgout-diff-latest ``` This commit fixes the problem. The fix is a bit clumsy, because the existing code is a bit clumsy and I didn't have the patience to do the big refactor required to fix it more nicely.
Kobzol
approved these changes
Feb 5, 2026
Member
Kobzol
left a comment
Kobzol
left a comment
There was a problem hiding this comment.
I vaguely remember this being annoying, yes 😆 The wonders of abstraction. Well, I think it's a good enough fix for now. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When you run a Cachegrind diff via
profile_localit produces a mix ofcgoutfiles (raw output) andcgannfiles (processed output). A couple of the files havecgoutprefixes when they should havecgannprefixes, e.g.:This commit fixes the problem. The fix is a bit clumsy, because the existing code is a bit clumsy and I didn't have the patience to do the big refactor required to fix it more nicely.