Report the real elapsed time of a download instead of the cumulative time #4460
Conversation
…tead of cumulative Before this commit, if RUSTUP_CONCURRENT_DOWNLOADS < 6, the timer for the components download would start at the same time for every one of them instead of just starting when the actual download begins.
| @@ -81,6 +81,7 @@ impl DownloadTracker { | |||
| /// Sets the length for a new ProgressBar and gives it a style. | |||
| pub(crate) fn content_length_received(&mut self, content_len: u64, url: &str) { | |||
| if let Some(pb) = self.file_progress_bars.get(url) { | |||
| pb.reset(); | |||
There was a problem hiding this comment.
Is it still useful that we're building the ProgressBar for DownloadingComponent, rather than starting at DownloadContentLengthReceived?
There was a problem hiding this comment.
I believe this is justifiable since we don’t have access to the component’s name when creating a DownloadContentLengthReceived notification -- only the URL.
With that in mind, and wishing to avoid parsing the URL to extract the component’s name, I think it’s best to keep the creation of the ProgressBar within the DownloadingComponent notification.
Additionally, I’d like to note that when retrying a download, the DownloadingComponent notification is not sent again. Moving the creation of the ProgressBar to the DownloadContentLengthReceived notification could complicate the logic in the DownloadTracker, particularly when handling download retries.
There was a problem hiding this comment.
Moreover, I’d like to add that creating the ProgressBar within DownloadingComponent is the only way to ensure the output remains in the correct order when handling concurrent downloads.
|
I think this looks okay. It seems a little unintuitive to me to wait until the |
Related to the introduction of the
RUSTUP_CONCURRENT_DOWNLOADSenvironment variable in #4450.This fixes the erroneous behavior of making the progress bar start ticking for all downloads at once, even when we are not in a situation of max concurrency.
PS: This situation can be observed in this animation (the first one).