-
Notifications
You must be signed in to change notification settings - Fork 985
dist: make installation asynchronous #4605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
rami3l
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look pretty reasonable and definitely an improvement over #4567’s attempt of spilling Arc everywhere.
I imagine that if correctly implemented, it would be equivalent to #4471 in terms of performance because as long as we are spawning the installation task, the extra overhead introduced by #4567 should be minimal.
It’s worth another bench nonetheless though.
PS: Would you mind investigating the CI failures? This implementation doesn’t seem to have covered all the edge cases.
|
Running On this PR: So it looks like this PR is a bit faster, by making better use of parallelism. On |
Oops, solved those. |
|
Thanks! I really want to test this with my own machine but I don't have my fiber installed until tomorrow... I hope you won't mind my delaying merging this for a bit just to be sure 🙏 |
|
No problem! Hope the fiber install will work out better for you tomorrow! |
cc @FranciscoTGouveia
async-install.mov