Fix zulip group zulip-id availability check #1977
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous
validate_zulip_group_ids
check logic is not quite correct in two ways:excluded-people
mechanism).extra-people
. It is possible to include a person whosepeople/
entry contain only a github handle, and not also a zulip id.Example
Consider the
cloud-compute
marker-team:The "all zulip group members must have a zulip-id" validation should fail, but not against
no_zulip_id
, because that member is not part of any zulip groups associated withcloud-compute
team. It should error onextra_no_zulip_id
however.Review remarks
Let me know if these validations have any tests... I can't figure out if the static-api tests are intended for this purpose, I don't think so. I tested these two cases manually, and the revised logic seems to behave as I would expect it to.