-
Notifications
You must be signed in to change notification settings - Fork 339
Remove try/auto homu branch protections from rust-lang/rust
#2216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Dry-run check results |
|
I don't think that there is any point in returning to homu now, so we can merge this. |
|
I think we want to delete the branches before/after merging this, right? Then they will no longer be used at all because we have the "cannot create branch" protection as well. I think before doing that we should try to double check that there's no AWS and/or GitHub state that references the branch name in OIDC or environment rules or similar, to avoid accidentally exposing credentials to some future creator of the branch name. I'm not sure if there's an authoritative way to do that unfortunately, but at minimum they should be removed from the bors environment (https://github.com/rust-lang/rust/settings/environments/5453059056/edit). |
|
This PR actually removes them from the bors environment, we can do that through team now :) Not sure about the OIDC stuff though, will check simpleinfra. |
|
Haven't found any references in simpleinfra, I think/hope we migrated everything to the |
|
[ERROR rust_team::validate] validation error: GitHub user Can anyone open a PR to fix this and I can approve and merge? |
|
Yes, I can do it |
|
Oh... it's the reverse of #2209 |

To be merged once we get rid of homu.We should double-check thathomuno longer has access to push to these branches (includingmain) after this is merged. We can also delete thetryandautobranches after this is merged.