Skip to content

Add support for only checking uncanonicalized issue links in commits - #2175

Merged
Urgau merged 1 commit into
rust-lang:masterfrom
Urgau:mentions-uncanonicalized-in-commits
Sep 5, 2025
Merged

Urgau merged 1 commit into
rust-lang:masterfrom
Urgau:mentions-uncanonicalized-in-commits

Conversation

@Urgau

@Urgau Urgau commented Sep 4, 2025

Copy link
Copy Markdown
Member

This PR adds support for only checking uncanonicalized issue links in commits.

[issue-links]
check-commits = "uncanonicalized"

Fixes #2173

@Urgau
Urgau requested a review from Kobzol September 4, 2025 17:03

@Kobzol Kobzol left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge with/without the nit.

View changes since this review

Comment thread src/config.rs Outdated
@Urgau
Urgau force-pushed the mentions-uncanonicalized-in-commits branch from 781e18a to e7b10b3 Compare September 5, 2025 16:37
@Urgau
Urgau added this pull request to the merge queue Sep 5, 2025
Merged via the queue into rust-lang:master with commit fcc12eb Sep 5, 2025
3 checks passed
@Urgau
Urgau deleted the mentions-uncanonicalized-in-commits branch September 5, 2025 16:52
@weihanglo

Copy link
Copy Markdown
Member

Would you like to document this new option in triagebot doc?

@weihanglo

Copy link
Copy Markdown
Member

And thanks!

@Urgau

Urgau commented Sep 8, 2025 •

Copy link
Copy Markdown
Member Author

Would you like to document this new option in triagebot doc?

Done in rust-lang/rust-forge#947. EDIT: wrong link, yes I should do that

@Urgau

Urgau commented Sep 9, 2025

Copy link
Copy Markdown
Member Author

Opened rust-lang/rust-forge#951

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make warning of issue links in commit message configurable

3 participants