Run Clippy - #2181
Run Clippy#2181
Conversation
If you can split into smaller commits, that would be great. Not necessarily each lint into it's own commit, bundling multiple lints changes is fine. |
|
I did try to group related lints, but there were many small commits left from lints that I couldn't find a good group for -- hopefully, having the lint name on those commits will at least make their intent clear. |
|
Thanks for splitting into many commits, that will help a lot. I will take a look at the PR in the next few weeks (I'm on vacation for the next two weeks). |
|
All the review comments should be addressed now, and the PR rebased on latest master A range-diff could've helped here 😅 |
Fortunately it's possible to ask triagebot nicely and it will give one nicely. :-) |
There was a problem hiding this comment.
Looks good to me. Will approve and merge in a few days unless someone (cc @Kobzol) wants to take a look before that.
|
Btw, it seems like my PR #2194 created a conflict with yours (sorry about that), could you rebase on master once again. |
Required for all the let-chains
clippy::{unused_lifetimes,elidable_lifetime_names}
clippy::{collapsible_match,unnested_or_patterns,match_same_arms}
takes up fewer lines
clippy::derivable_impls
clippy::{semicolon_if_nothing_returned,unnecessary_semicolon}
pointed out by `clippy::type_complexity`
clippy::{format_collect,format_push_string,useless_format}
much more concise
the `push` used to be conditional
2 participants
For #1950
This turned out rather big... I'd like to make this easier to review, but I'm not sure how -- maybe split each lint's changes into its own commit?