Skip to content

Improvements to the assign-priority command - #2516

Merged
Urgau merged 1 commit into
rust-lang:mainfrom
apiraino:assign-prio-improvements
Sep 29, 2026
Merged

Urgau merged 1 commit into
rust-lang:mainfrom
apiraino:assign-prio-improvements

Conversation

@apiraino

@apiraino apiraino commented Sep 26, 2026 •

Copy link
Copy Markdown
Contributor

This patch adds a few small changes to the issue prioritization triagebot
Zulip command:

  • It is now accepted the shortcut "prio"
  • The issue number is optional. If omitted it is searched in Zulip topic title
  • When we edit the Zulip topic, we ensure we do not set the same topic
    (the Zulip API returns an error)

Examples:

triagebot assign-priority high 123456
triagebot prio medium 123456
triagebot prio high

This will change the syntax of the command so I will update the documentation.

@apiraino
apiraino requested a review from Urgau September 26, 2026 16:38

@Urgau Urgau left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small nits, otherwise looks good.

View changes since this review

Comment thread src/zulip/commands.rs
Comment thread src/zulip.rs Outdated
This patch adds a few small changes to the issue prioritization triagebot
Zulip command:
- It is now accepted the shortcut "prio"
- The issue number is optional. If omitted it is searched in Zulip topic title
- When we edit the Zulip topic, we ensure we do not set the same topic
  (the Zulip API returns an error)

Examples:
```
triagebot assign-priority high 123456
triagebot prio medium 123456
triagebot prio high
```

This will change the syntax of the command so I will update the documentation.
@apiraino
apiraino force-pushed the assign-prio-improvements branch from 5dbda8e to e747558 Compare September 29, 2026 15:56
@apiraino
apiraino requested a review from Urgau September 29, 2026 15:56
@apiraino

Copy link
Copy Markdown
Contributor Author

thanks

@Urgau Urgau left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Urgau
Urgau added this pull request to the merge queue Sep 29, 2026
Merged via the queue into rust-lang:main with commit be171d7 Sep 29, 2026
4 checks passed
@apiraino
apiraino deleted the assign-prio-improvements branch September 29, 2026 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants