Skip to content

Conversation

bytesnake
Copy link
Member

This is WIP

 * introduce polars behind feature flag
 * add `Dataframe` type
 * add income dataset which mixes categorical and numerical features
 * implement records for `polars::DataFrame`

CsvReader::new(buf)
.infer_schema(None)
.has_header(false)
Copy link
Contributor

@bernardo-sb bernardo-sb Oct 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this option be given as a function argument has_header: bool?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, Is not it better to have direct arrow support than providing support for polars. So that any dataframe library based on arrow2 can use the preprocessing, and training methods? I am new to Rust and lifa project my question could be stupid. Thanks in advance for any clarity.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, Is not it better to have direct arrow support than providing support for polars. So that any dataframe library based on arrow2 can use the preprocessing, and training methods? I am new to Rust and lifa project my question could be stupid. Thanks in advance for any clarity.

But there is so many unique implementations of arrow2 I feel the api should be developed so you can byo arrow2 implementation, this may already an issue, if not I thought I would mention it and maybe I could come up with a poc pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants