Skip to content

Fix for abi_x86_interrupt for newest nightly 1.90 #558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

rsahwe
Copy link

@rsahwe rsahwe commented Jul 20, 2025

#553

This fix just removes all of the diverging. This would be a breaking change and might cause undesired behavior.

Alternatively the idt could maybe use wrapper functions so that the handler functions don't have the x86_interrupt abi.

@Freax13
Copy link
Member

Freax13 commented Jul 20, 2025

Hi @rsahwe, thank you for your contribution!

As you noticed, rustc no longer accepts -> ! as the return type for "x86-interrupt". This is a regression in rustc. There is ongoing work to fix this. Given this, we hope that once this is eventually fixed in rustc, we won't need to make any changes to this crate.

If we make a breaking change now, we'll likely have to do another breaking change to revert that once the rustc fix lands, so I think we should wait for now.

Until then, you'll have to pin your nightly version or disable the abi_x86_interrupt feature. I recognize that this is not ideal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants