Add windows_legacy opt-in backend
#724
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newpavlov
changed the title
windows-legacy opt-in backendwindows_legacy opt-in backend
josephlr
reviewed
Sep 29, 2025
| match rustc_minor_version() { | ||
| Some(minor_ver) if minor_ver < WIN7_INTRODUCED_MINOR_VER => { | ||
| println!("cargo:rustc-cfg=getrandom_windows_legacy"); | ||
| println!("cargo:rustc-cfg=getrandom_backend=\"windows_legacy\""); |
There was a problem hiding this comment.
One thing that concerned me about this line is if it would override users who used --getrandom_backend="whatever" on Windows when using an older compiler.
Turns out, I can be an issue, but depends on the value of "whatever". Opened #728 to fix.
|
Other than #728, this looks good. Thanks for taking care of this. It makes things a lot clearer to the user. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some users may prefer to use the legacy Windows backend (e.g. see #723), so I think it's worth to introduce a documented configuration flag for it and replace the undocumented
getrandom_windows_legacyflag.