Skip to content

Add assume_wasm_js feature #726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Add assume_wasm_js feature #726

wants to merge 2 commits into from
+37 −22

Conversation

dhardy
Copy link
Member

@dhardy dhardy commented Sep 22, 2025

Essentially this is #675. Partial alternative to #725.

newpavlov
newpavlov reviewed Sep 22, 2025
View reviewed changes
@dhardy dhardy mentioned this pull request Sep 22, 2025
Closed
@newpavlov newpavlov mentioned this pull request Sep 22, 2025
Closed
josephlr
josephlr requested changes Sep 29, 2025
View reviewed changes
Copy link
Member

@josephlr josephlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should do this. Having two features makes things more confusing to me. One wasm_js feature is enough. Going with #675 seems better, see my comment: #675 (comment)

@dhardy dhardy mentioned this pull request Sep 29, 2025
Merged
josephlr pushed a commit that referenced this pull request Oct 13, 2025
@dhardy
Implement #675: let wasm_js enable the backend by default (#730)
1af2510 
Implements #675. Closes #726.

Now, when the `wasm_js` feature is enabled and `getrandom_backend` is not specified, this crate will use the `wasm_js` implementation by default (instead of failing to compile).

The backend my still be overridden via `getrandom_backend` as with any other platform.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@newpavlov newpavlov newpavlov left review comments

@josephlr josephlr josephlr requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dhardy @newpavlov @josephlr