build_container: Allow pip to install system-wide#123
Merged
stefano-garzarella merged 2 commits intorust-vmm:mainfrom Mar 5, 2025
Merged
build_container: Allow pip to install system-wide#123stefano-garzarella merged 2 commits intorust-vmm:mainfrom
stefano-garzarella merged 2 commits intorust-vmm:mainfrom
Conversation
We are having `error: externally-managed-environment` after upgrading to ubuntu:24.04. Remove `EXTERNALLY-MANAGED` file to allow pip to install packages system-wide. Signed-off-by: Ruoqing He <heruoqing@iscas.ac.cn>
7a4064f to
151c870
Compare
Member
|
@RuoqingHe LGTM, just some notes about the commit message:
Is |
Member
Author
Thanks for helping me with wording, I was struggling how to phrase this commit message 😂 |
Even if we have `set -e`, if `pip install` fails, the script goes on because we use the && operator. Avoid this to make sure that we discover any errors with `pip install`. Signed-off-by: Ruoqing He <heruoqing@iscas.ac.cn>
151c870 to
0227b70
Compare
stefano-garzarella
approved these changes
Mar 4, 2025
roypat
approved these changes
Mar 4, 2025
Member
roypat
left a comment
There was a problem hiding this comment.
ah nice, I was wondering how we ended up without pytest in the container haha
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the PR
Found in https://github.com/rust-vmm/rust-vmm-container/actions/runs/13650154708/job/38156682477#step:7:2290.
We are having
error: externally-managed-environmentafter upgrading to ubuntu:24.04. RemoveEXTERNALLY-MANAGEDfile to allow pip to install packages system-wide.And even if we have
set -e, ifpip installfails, the script goes on because we use the && operator.Avoid this to make sure that we discover any errors with
pip install.Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commit message has max 60 characters for thesummary and max 75 characters for each description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafecode is properly documented.