chore: update Rust to 1.87 #132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uran0sH
requested review from
andreeaflorescu,
lauralt,
stefano-garzarella,
stsquad,
roypat,
ShadowCurse and
RuoqingHe
as code owners
stefano-garzarella
approved these changes
Jul 9, 2025
roypat
approved these changes
Jul 9, 2025
roypat
added a commit
to roypat/rust-vmm-container
that referenced
this pull request
Jul 10, 2025
Without this, PRs that for example update the rust toolchain (see rust-vmm#132 for an example) will not trigger the workflow, but since the workflow is required, they will not be able to get merged). Signed-off-by: Patrick Roy <[email protected]>
roypat
added a commit
to roypat/rust-vmm-container
that referenced
this pull request
Jul 10, 2025
It's better to build too many docker containers than too few, so let's go with not triggering the build if we know that only files irrelevant to the container are modified (instead of trying to explicitly list all files that are relevant). This way, if the list is stale, we build "too many" containers, whereas with the current solution, we build "too few" containers (see for example rust-vmm#132). Signed-off-by: Patrick Roy <[email protected]>
stefano-garzarella
pushed a commit
that referenced
this pull request
Jul 10, 2025
It's better to build too many docker containers than too few, so let's go with not triggering the build if we know that only files irrelevant to the container are modified (instead of trying to explicitly list all files that are relevant). This way, if the list is stale, we build "too many" containers, whereas with the current solution, we build "too few" containers (see for example #132). Signed-off-by: Patrick Roy <[email protected]>
Signed-off-by: Wenyu Huang <[email protected]>
stefano-garzarella
force-pushed
the
update-rust
branch
from
ead38a6 to
f3b584f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
Update Rust version for using some features available in 1.87, like
std::io::pipeRequirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commit message has max 60 characters for thesummary and max 75 characters for each description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafecode is properly documented.