Skip to content

Install lsof into container #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 25, 2025
Merged

Conversation

uran0sH
Copy link
Contributor

@uran0sH uran0sH commented Jul 24, 2025

Summary of the PR

Install lsof in container to check the process's fd
For example, verify whether CLOEXEC flag works
in a unit test, like unit tests in rust-vmm/vmm-sys-util#244?

Requirements

Before submitting your PR, please make sure you addressed the following
requirements:

  • [ x ] All commits in this PR have Signed-Off-By trailers (with
    git commit -s), and the commit message has max 60 characters for the
    summary and max 75 characters for each description line.
  • All added/changed functionality has a corresponding unit/integration
    test.
  • All added/changed public-facing functionality has entries in the "Upcoming
    Release" section of CHANGELOG.md (if no such section exists, please create one).
  • Any newly added unsafe code is properly documented.

@roypat
Copy link
Member

roypat commented Jul 25, 2025

Could you add some context in the commit / PR description about where we would like to use this? I'm assuming its unit tests in rust-vmm/vmm-sys-util#244?

Copy link
Member

@stefano-garzarella stefano-garzarella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rebase on main ?

Install lsof in container to check the process's fd
For example, verify whether CLOEXEC flag works
in a unit test

Signed-off-by: Wenyu Huang <[email protected]>
@uran0sH
Copy link
Contributor Author

uran0sH commented Jul 25, 2025

Can you rebase on main ?

done

@uran0sH
Copy link
Contributor Author

uran0sH commented Jul 25, 2025

Could you add some context in the commit / PR description about where we would like to use this? I'm assuming its unit tests in rust-vmm/vmm-sys-util#244?

Add in commit and pr. Please check if it is clear.

@stefano-garzarella stefano-garzarella merged commit 260df6e into rust-vmm:main Jul 25, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants