vhost-user: Add support for GET_SHMEM_CONFIG message #339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aesteve-rh
requested review from
Ablu,
epilys,
eryugey,
germag,
jiangliu,
sboeuf,
slp and
stefano-garzarella
as code owners
Contributor
Author
Add support for GET_SHMEM_CONFIG message to retrieve VirtIO Shared Memory Regions configuration. This is useful when the frontend is unaware of specific backend type and configuration of the memory layout. Based on the patch [1] which is just waiting for being merged. [1] - https://lore.kernel.org/all/[email protected]/ Signed-off-by: Albert Esteve <[email protected]>
aesteve-rh
force-pushed
the
mmap-backend-cmd
branch
from
c1382e5 to
f93cc74
Compare
fkm3
reviewed
Dec 17, 2025
| /// Padding for correct alignment | ||
| padding: u32, | ||
| /// Size of each memory region | ||
| pub memory_sizes: [u64; 8], |
There was a problem hiding this comment.
the spec is a bit ambiguous and i don't see a QEMU implementation yet, but it sounds like this is supposed to be variable length in the wire protocol. you could of course choose to only support 8 in this library, but then i think you still need to adjust the code to read/write these values from the socket correctly + error or something in VhostUserShMemConfig::new if nregions is too big
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for GET_SHMEM_CONFIG message to retrieve VirtIO Shared Memory Regions configuration.
This is useful when the frontend is unaware of specific backend type and configuration of the memory layout.
Based on the patch [1] which is just waiting for being merged.
[1] -
https://lore.kernel.org/all/[email protected]/
Summary of the PR
Please summarize here why the changes in this PR are needed.
Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commit message has max 60 characters for thesummary and max 75 characters for each description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafecode is properly documented.