Implemented dynamic loading of xcb, xlib_xcb and xlib. #287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e libraries is now possible if they aren't required anymore. Refactored some library loading in contexts without a connection so that the loaded library is kept alive while the function pointers are also alive.
…duplicated between the dynamic linking and loading. This is done through a macro. Switched over to using libloading for a more robust implementation of library loading.
…bLib is documented like the extern functions were before.
Collaborator
|
Hi, thanks a lot. this is a long time needed feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements dynamic loading of the xcb library through the
dlfeature flag and dynamic loading of xlib through thexlib_xcb_dlfeature flag.When
xlib_xcb_dlis specifiedx11-dlis used instead ofx11, which is why I used another feature flag. It is possible to specify bothxlib_xcbandxlib_xcb_dl, in which casexlib_xcb_dlhas precedence. This means thatcargo test --all-featureswill always test with dynamic loading.Loading of the libraries is mostly analogous to how x11-dl does it, with minor changes to error reporting and the usage of OnceLock instead of OnceCell.
For the user of this crate dynamic loading is mostly invisible, since loading of the library is bound to the connection. It only currently gets messy in the opengl_window example, where I needed to support both dynamic loading and dynamic linking for xlib and glx due to being able to support
cargo test --all-featuresin addition to it's default required features.Closes #88