Ftw chmod #376
Merged
Ftw chmod #376
+744
−186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
143h2ng
approved these changes
Nov 21, 2024
JRF63
force-pushed
the
ftw-chmod
branch
3 times, most recently
from
900b87b to
2bdd15d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
modestr::mutatemodestr::mutatetestsftwon chmodThis mostly matches coreutils' behavior with the exception of these two:
Allowing the use of octal integers in conjuction with +, - or =.
This seems to conflict with the "For an octal integer mode operand, the file mode bits shall be set absolutely" in the standard.
Ex:
When removing permissions, error when umask conflicts with unspecified
who(u, g, or o not specified).This one isn't in the spec and coreutils' handling is rather arbitrary (only gives the error when there is a single clause).
Ex:
touch f chmod 777 f chmod -w f # chmod: f: new permissions are rwxrwxrwx, not r-xr-xr-x