Windows long is always 4 bytes wide #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filmor
force-pushed
the
windows-long-width
branch
from
15c00b4 to
9b0ea12
Compare
filmor
force-pushed
the
windows-long-width
branch
from
9b0ea12 to
abfe1b8
Compare
scrogson
approved these changes
Nov 20, 2019
scrogson
reviewed
Nov 20, 2019
rustler_sys/build.rs
Outdated
| Ok(ref val) => panic!("Unsupported target pointer width: {}", val), | ||
| Err(err) => panic!( | ||
| // get size of C long | ||
| let long_width = match (env::var("CARGO_CFG_TARGET_POINTER_WIDTH"), env::var("CARGO_CFG_TARGET_OS")) { |
There was a problem hiding this comment.
Maybe pull these into vars above to clean up the formatting?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #284.