fix: handle nested HTML tags in the config #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcgruenhage
commented
Sep 3, 2020
| @@ -71,7 +71,7 @@ impl<'a> Changelog<'a> { | |||
|
|
|||
| let mut log = tera.render("template", &context)?; | |||
| if let Some(metadata) = &self.config.metadata { | |||
| log.push_str(&format!("\n{}\n", metadata)); | |||
| log.push_str(&format!("\n\n{}\n", metadata)); | |||
There was a problem hiding this comment.
I'm a bit confused here, without this the diff says one newline has been removed, but I don't see how my code removes more newlines than the old code. When explicitly adding this newline in the config parsing instead of adding it here, the diff says there's an extra newline. I'm really a bit lost here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #14. I'm not 100% happy with that code, but I'm not sure how to handle this better.