Add support for all Diffie-Hellman Key Exchange protocols. #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the SSH 2.0 protocol, there are roughly three different Diffie-Hellman key exchange protocols: - The first one, simply called Diffie-Hellman Key Exchange, defined in [RFC4253 § 8](https://datatracker.ietf.org/doc/html/rfc4253#section-8) - The second one that use ECDH, defined in [RFC6239 § 4](https://datatracker.ietf.org/doc/html/rfc6239#section-4) - The last one, called Diffie-Hellman Group and Key Exchange, defined in [RFC4419 § 3](https://datatracker.ietf.org/doc/html/rfc4419#section-3) The Diffie-Hellman key exhange protocol depends on the KEX algorithms that has been negociated during the _Key Exchange Init_ stage. This commit adds support for these three Diffie-Hellman key exchange protocols, by implementing a new API called `SshKEX`. To use `SshKEX`, users must have retrieved the `SshPacketKeyExchange` from the client and the server. Then, `SshKEX::init` is called to initialize the KEX stage. Later, depending on the type of the messages that come, `SshKEX::parse_ssh_packet` is called to feed the pending KEX stage. Finally, the various sub-stages specific to each DH key exchange protocols are exposed through the `SshKEX` interface. Tests have been added to ensure that these three protocols are well supported. If the feature flag `integers` is enabled, some sub-stages may expose `BigInt` instead of the integers in raw format. No copy or no memory allocation is used here. Signed-off-by: gcsbt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the SSH 2.0 protocol, there are roughly three different Diffie-Hellman key exchange protocols:
The Diffie-Hellman key exhange protocol depends on the KEX algorithms that has been negociated during the Key Exchange Init stage.
This commit adds support for these three Diffie-Hellman key exchange protocols, by implementing a new API called
SshKEX.To use
SshKEX, users must have retrieved theSshPacketKeyExchangefrom the client and the server. Then,SshKEX::initis called to initialize the KEX stage.Later, depending on the type of the messages that come,
SshKEX::parse_ssh_packetis called to feed the pending KEX stage.Finally, the various sub-stages specific to each DH key exchange protocols are exposed through the
SshKEXinterface.Tests have been added to ensure that these three protocols are well supported.
If the feature flag
integersis enabled, some sub-stages may exposeBigIntinstead of the integers in raw format.No copy or no memory allocation is used here.
Notes
To give credit where it's due, I'm not the author of this PR (which is preserved in the git commit).
I just rebased the original PR on
masterand fix a few warnings here and there.