Add AbstractRange and StaticRange interfaces
#4221
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behrenle
force-pushed
the
add-static-range-interface
branch
from
c73ef02 to
2298ee6
Compare
daxpedda
requested changes
Nov 9, 2024
behrenle
force-pushed
the
add-static-range-interface
branch
from
e8fd5f4 to
d2f1cb9
Compare
behrenle
force-pushed
the
add-static-range-interface
branch
from
d2f1cb9 to
576087a
Compare
|
@daxpedda I have incorporated your requested changes and would appreciate another review. Unfortunately, I can't remove the 'waiting for author' label myself. |
|
Ah, this PR is just what i need, thank you @behrenle |
|
Oh, unfortunately i can't use this as a git dependency due to the "links" tag - It's not impossible to get it to work temporarily, but i would definetely appreciate if this were merged sometime in the coming months |
|
@kartonrad I’m facing the same issue, but I’m still waiting for a follow-up review from @daxpedda. Hopefully, we can get this merged soon! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for the
AbstractRangeandStaticRangeinterfaces to wasm-bindgen, enabling Rust developers to interact with these DOM range objects for improved web API compatibility.