Skip to content

Fix order of loading files in tests, fixes #14#16

Open
mpapis wants to merge 1 commit into
masterfrom
bugfix/ensure-order-of-loading-files-in-tests
Open

Fix order of loading files in tests, fixes #14#16
mpapis wants to merge 1 commit into
masterfrom
bugfix/ensure-order-of-loading-files-in-tests

Conversation

@mpapis

@mpapis mpapis commented Jun 25, 2017

Copy link
Copy Markdown
Member

The following line:

Dir[lib+"/**/*.rb"].each{|file| require file }

can have system dependent ordering, adding extra:

require "pluginator"

should ensure proper order of loading classes.

@mpapis mpapis mentioned this pull request Jun 25, 2017
@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 100.0% when pulling 9b989e6 on bugfix/ensure-order-of-loading-files-in-tests into e205d0e on master.

@logicminds

logicminds commented Sep 3, 2017

Copy link
Copy Markdown
Contributor

This seems to fix the original issue. However, I am now getting other errors. Looking into those errors now.

@mpapis

mpapis commented Sep 10, 2017

Copy link
Copy Markdown
Member Author

share the errors, I might be able to help :)

@mpapis

mpapis commented Jan 25, 2018

Copy link
Copy Markdown
Member Author

@logicminds ping :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants