Skip to content

Conversation

@assarbad
Copy link

...changed 'file' (a keyword) to 'rcsfile' in the ctor and made self._filename a tuple

I apologize on behalf of my editor which tends to strip trailing whitespace.

The exposed properties allow me to derive a class and do meaningful stuff in that derived class, since all relevant parsing data is now available.

This includes the fixes suggested in Issue #1 of the upstream repo.

As a side-note: your code ran fine with pyparsing 2.0.3.

…so changed 'file' (a keyword) to 'rcsfile' in the ctor and made self._filename a tuple
Copy link

@xipmix xipmix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing piece of this patch

--- a/rcsgrep
+++ b/rcsgrep
@@ -57,7 +57,7 @@ if __name__ == '__main__':
         sys.exit(parser.print_help())
     pattern = args[0]
     for filename in args[1:]:
-        f = RCSFile(file=filename)
+        f = RCSFile(rcsfile=filename)
         for match in f.grep(pattern, format=options.format,
                             wraplines=options.linewraps):
             if options.sep:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants