Merged
Conversation
Sync with https://github.com/ryanlua/purse/tree/51b9ef56e2c58867777b1b455a792835be2e99ce/.github/workflows Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request modernizes the GitHub Actions workflows by consolidating CI steps, automating releases via tag pushes, and simplifying documentation deployment. The changes reduce manual intervention and streamline the build and release pipeline.
Key changes:
- Consolidated separate lint, style, and build jobs into a single CI workflow job with comprehensive validation
- Changed release trigger from manual workflow dispatch to automatic execution on version tags
- Simplified documentation deployment by removing the
mikeversioning tool in favor of directmkdocs gh-deploy
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| models/SatchelLoader/Satchel/init.luau | Fixed indentation by removing leading whitespace |
| .github/workflows/ci.yml | Consolidated lint, style, and build steps into a single job with Wally type generation and artifact uploads |
| .github/workflows/release.yml | Automated release process with tag-based triggers, removed draft mode, and aligned build steps with CI workflow |
| .github/workflows/documentation.yml | Simplified deployment by removing mike versioning, added src directory to sparse checkout |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ryanlua/purse#20
This pull request updates the project's GitHub Actions workflows to streamline CI, documentation deployment, and release processes. The main improvements include consolidating build, lint, and style steps into a single workflow, enhancing the build process with additional tooling, simplifying documentation deployment, and automating releases based on tag pushes.
CI and Build Process Improvements:
Combined lint, style, and build steps into a single
buildjob in.github/workflows/ci.yml, adding environment variables and updating the setup to useRokitandWallyfor dependency management and type generation. The build now produces both.rbxmand.rbxmxartifacts, which are archived for later use.Enhanced the release workflow in
.github/workflows/release.ymlto mirror the improved build process, including type generation and consistent artifact naming using theOUTPUT_NAMEenvironment variable. [1] [2]Release Automation:
v*.*.*pattern, streamlining the release process and reducing manual intervention.Documentation Deployment Simplification:
Simplified the documentation workflow in
.github/workflows/documentation.ymlby removing theVERSIONenvironment variable and switching frommiketo a directmkdocs gh-deploy --forcecommand for deploying documentation, making the process more straightforward. [1] [2]Updated the documentation workflow's checkout step to include the
srcdirectory in addition todocs, ensuring all necessary files are available for documentation builds.