Improve environment compatibility for React Native and others #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed cheerio dependency and its usage in the code. - Added jsdom and @xmldom/xmldom for HTML parsing. - Implemented a new private method #parseHTML to handle HTML string parsing. - Updated the code to use the new parsing method for extracting data from HTML responses. chore: update package.json and yarn.lock - Added jsdom and @xmldom/xmldom to dependencies in package.json. - Removed cheerio from dependencies in package.json. - Updated yarn.lock to reflect the changes in dependencies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @s0ftik3!
This pull request addresses an incompatibility issue with React Native environments. The changes implemented here ensure the library functions correctly regardless of the user's environment.
I have verified this implementation in:
22.14.00.79.1Please review these changes. If you encounter any issues or have feedback, please leave a comment.
Thank you for considering these modifications.