Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instruction to enable git color (fixes #1) #2

Merged
merged 2 commits into from
Oct 10, 2017
Merged

Add instruction to enable git color (fixes #1) #2

merged 2 commits into from
Oct 10, 2017

Conversation

wyudong
Copy link
Contributor

@wyudong wyudong commented Sep 30, 2017

No description provided.

@saadq
Copy link
Owner

saadq commented Sep 30, 2017

Ahh, sorry I meant that in the PR you can just actually remove those styles that blocked the Git syntax highlighting. So just delete the lines that I mentioned (and the ones you mentioned).

And then, in the Recommended Styles, you can say to add the following to your custom stylesheet:

// Remove Git highlighting from tree view
.status-modified,
.status-added,
.status-renamed,
.status-removed {
  color: inherit;
  background-color: inherit;

  &.directory > .list-item {
    color: inherit !important;
    background-color: inherit !important;
  }

  &.directory.selected > .list-item {
    color: inherit !important;
    background-color: inherit !important;
  }
}

.tree-view {
  .icon-file-text, .icon {
    color: #c0c0c0;
  }
}

@wyudong
Copy link
Contributor Author

wyudong commented Sep 30, 2017

Haha, your way is much more better. I will make another PR in a short time.

@saadq
Copy link
Owner

saadq commented Sep 30, 2017

Sounds good, and thanks for your time!

@wyudong wyudong closed this Oct 10, 2017
@wyudong wyudong reopened this Oct 10, 2017
@wyudong
Copy link
Contributor Author

wyudong commented Oct 10, 2017

PR done and README updated. The issue exists in apex-ui too: apex/apex-ui#26

@saadq
Copy link
Owner

saadq commented Oct 10, 2017

Awesome work! I like the approach of changing the color of .icon. Thanks very much for the help on this :)

@saadq saadq changed the title Add instruction to enable git color Add instruction to enable git color (fixes #1) Oct 10, 2017
@saadq saadq merged commit 062d543 into saadq:master Oct 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants