-
Notifications
You must be signed in to change notification settings - Fork 1
Merge stale content editor branch #447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| | "success" | ||
| | "info"; | ||
|
|
||
| // AL: badgeType arg? TODO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does this work with existing shoelace badges?
zachharrison
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs a little cleanup plus we are going to want to merge in production and deploy new versions for Mint & Bedrock
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates documentation annotations across several component files, primarily correcting naming inconsistencies and improving example labels in JSDoc comments.
Key Changes:
- Standardized "Reward Table" to "Rewards Table" naming in column components
- Enhanced the Anonymous Leaderboard example with a visual layout including an image and descriptive text
- Simplified example labels for better clarity
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| sqm-widget-verification.tsx | Added exampleGroup and example annotations for Widget Verification component |
| sqm-rewards-table-source-column.tsx | Corrected component name from "Reward Table" to "Rewards Table" |
| sqm-rewards-table-note-column.tsx | Corrected component name from "Reward Table" to "Rewards Table" |
| sqm-leaderboard.tsx | Enhanced Anonymous Leaderboard example with a more comprehensive visual layout |
| sqm-invoice-table-date-column.tsx | Simplified example label from "Invoice Table Date Column" to "Date Column" |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Description of the change
Type of change
Links
Checklists
Development
Paperwork
Code review