Skip to content

Conversation

@noahwc
Copy link
Contributor

@noahwc noahwc commented Jul 17, 2025

Description of the change

Description here

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation or Development tools (readme, specs, tests, code formatting)

Links

  • Jira issue number: (PUT IT HERE)
  • Process.st launch checklist: (PUT IT HERE)

Checklists

Development

  • Prettier was run (if applicable)
  • The behaviour changes in the pull request are covered by specs
  • All tests related to the changed code pass in development

Paperwork

  • This pull request has a descriptive title and information useful to a reviewer
  • This pull request has a Jira number
  • This pull request has a Process.st launch checklist

Code review

  • Changes have been reviewed by at least one other engineer
  • Security impacts of this change have been considered

@noahwc noahwc mentioned this pull request Jul 17, 2025
12 tasks
@noahwc noahwc requested a review from zachharrison July 17, 2025 22:58
Base automatically changed from feature/content-editor to master October 22, 2025 22:37
| "success"
| "info";

// AL: badgeType arg? TODO
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this work with existing shoelace badges?

Copy link
Contributor

@zachharrison zachharrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a little cleanup plus we are going to want to merge in production and deploy new versions for Mint & Bedrock

Copilot AI review requested due to automatic review settings November 26, 2025 19:48
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates documentation annotations across several component files, primarily correcting naming inconsistencies and improving example labels in JSDoc comments.

Key Changes:

  • Standardized "Reward Table" to "Rewards Table" naming in column components
  • Enhanced the Anonymous Leaderboard example with a visual layout including an image and descriptive text
  • Simplified example labels for better clarity

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
sqm-widget-verification.tsx Added exampleGroup and example annotations for Widget Verification component
sqm-rewards-table-source-column.tsx Corrected component name from "Reward Table" to "Rewards Table"
sqm-rewards-table-note-column.tsx Corrected component name from "Reward Table" to "Rewards Table"
sqm-leaderboard.tsx Enhanced Anonymous Leaderboard example with a more comprehensive visual layout
sqm-invoice-table-date-column.tsx Simplified example label from "Invoice Table Date Column" to "Date Column"

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants