docs: add review-learnings doc distilled from recent PRs#3057
Open
vseehausen wants to merge 2 commits into
Open
docs: add review-learnings doc distilled from recent PRs#3057vseehausen wants to merge 2 commits into
vseehausen wants to merge 2 commits into
Conversation
vseehausen
changed the title
vseehausen
force-pushed
the
valentin/pr-review-learnings-skill
branch
from
8424a30 to
bc489ff
Compare
Move the growing set of PR review conventions out of AGENTS.md into docs/review-learnings.md, leaving a one-paragraph pointer behind. Why: AGENTS.md auto-loads into every Claude Code session in the repo, so every token there costs context across all work. Review learnings grow over time as we extract more patterns from PR comments; keeping them in a dedicated file lets the conventions compound without inflating the always-on context. The separate file is maintained semi-automatically by the new /safe-engineering:pr-learnings skill (opened as a separate PR on safe-global/safe-engineering-plugin), which scans recent PR comments on each run, extracts recurring patterns, merges them into existing rules without duplicating, and updates a resume ledger at the top of the file. Initial content distilled from 412 human review comments across 74 PRs in the 2026-02-23 → 2026-04-23 window. Ledger line at the top of the file records the range and the date to resume from next run. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
vseehausen
force-pushed
the
valentin/pr-review-learnings-skill
branch
from
bc489ff to
750a838
Compare
vseehausen
force-pushed
the
valentin/pr-review-learnings-skill
branch
from
0386224 to
8131194
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
docs/review-learnings.mdwith review conventions distilled from recent PRs, and a pointer to it inAGENTS.md.Changes
docs/review-learnings.md— conventions grouped by topic: module layout, naming, types & schemas, reuse, controllers, auth, DB, logging, config, testing, code style, security, PR hygiene, Biome.AGENTS.md— 4-line pointer to the new file.Ledger line at the top of the new file records the analyzed window so future runs of
/safe-engineering:pr-learningscan resume from there.