This repository was archived by the owner on Mar 18, 2022. It is now read-only.
Adding Mobile Views for charts.#1
Open
JessicaInTime wants to merge 8 commits into
Open
Conversation
there are 2 main issues still need to be fixed, 1 being the height of the svg viewport, needs to be correctly calculated for to display all of the bar chart and size the chart accordingly for the mobile view to be about have the height of the screen viewport. 2 is the text colour in the bar chart on the darker bar colours, need to figure out a way to have the appropriate text colour for display because some text in the chart will be ontop of a whiteback ground or a coloured bar.
Unfortunately using a gradient didn't work due to the bar colours not blending well with grey like colours on top
The tick labels are now moved inside the chart and the chart expands its width for a mobile screen When in a mobile view, clicking on a colour bar group will now move the text to the beyond the end of the bar, to help readability
Also included the white space fixes for certain sizes Added bounce animation for when the range chart is over the stop points
JessicaInTime
commented
Nov 12, 2018
Author
JessicaInTime
left a comment
JessicaInTime
left a comment
There was a problem hiding this comment.
@vladh already spotted a couple warts =((
| let legend = this.g | ||
| .append('g') | ||
| .attr('class', 'legend') | ||
| .attr('transform', `translate(0, ${24})`) |
Author
There was a problem hiding this comment.
Oops =( this was a test, anyways, i will update this when fixing the legend for the stacked chart.
| .extra-details__content | ||
| margin-top 2rem | ||
|
|
||
| @media screen and (min-device-width: 375px) and (max-device-width: 667px) |
Author
There was a problem hiding this comment.
Need to fix this to be min-device-width 360px
| "private": true, | ||
| "dependencies": { | ||
| "async": "^1.5.0", | ||
| "current-device": "^0.7.8", |
Author
There was a problem hiding this comment.
Oops forgot the package-lock.json need to update this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains all the changes for the Map, Range, Bar and Stack charts that needed to be updated or written for a mobile/tablet view.
These changes should not affect the desktop view unless the desktop viewport has been made to a much narrower view.