Use ring.is_finite() for Sp invariant_form check #39858
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes sagemath#36441 The check for whether a custom invariant_form could be used with Sp(n, R) incorrectly used `isinstance(ring, FiniteField)`. Due to this it failed to detect finite rings like Zmod(p) (p prime), leading to the invariant_form being silently ignored by GAP instead of raising the expected NotImplementedError. Changed the check to `ring.is_finite()`, which fixes the described limitation. Added Doctests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #36441
The check for whether a custom invariant_form could be used with Sp(n, R) incorrectly used
isinstance(ring, FiniteField). Due to this it failed to detect finite rings like Zmod(p) (p prime), leading to the invariant_form being silently ignored by GAP instead of raising the expected NotImplementedError.Changed the check to
ring.is_finite(), which fixes the described limitation.Added Doctests.
📝 Checklist
⌛ Dependencies