Deprecate negative k in Combinations #39868
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes sagemath#39411 Implemented deprecation for handling negative k values passed to Combinations(mset, k), Added an `allow_negative` keyword argument: - None (default): Returns empty list, gives DeprecationWarning (once per instance). - True: Returns empty list, no warning. - False: Raises ValueError. Updated the implementation to use a helper method `_handle_negative_k` in the base class Combinations_msetk to avoid code duplication( especially while giving warnings, had issues with this while testing). Ensuring the same added a flag `_issued_negative_k_warning` to ensure the deprecation warning is only shown once per object. Added Doctests for this new behaviour.
|
@DaveWitteMorris hello, can you please review this and give feedback for the same, |
|
@EigenVector22 There were already people working on this issue. Please choose an issue that has not already been claimed, unless you get permission from the people who have claimed it (or the issue has been abandoned for a long time, which is not the case here). |
|
my bad, sure, i'll communicate with people working on this and accordingly close the PR if they are ready, |
|
@DaveWitteMorris again apologies, I've communicated with both the people on the issue thread, the issue has been resolved, can refer the issue thread for confirmation. Any feedback to improve the above implementation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #39411
Implemented deprecation for handling negative k values passed to Combinations(mset, k),
Added an
allow_negativekeyword argument:Updated the implementation to use a helper method
_handle_negative_kin the base class Combinations_msetk to avoid code duplication( especially while giving warnings, had issues with this while testing). Ensuring the same, added a flag_issued_negative_k_warningto ensure the deprecation warning is only shown once per object.Added doctests for this new behaviour.
📝 Checklist
⌛ Dependencies