Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make generic polynomial multiplication interruptible #39884

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

user202729
Copy link
Contributor

@user202729 user202729 commented Apr 5, 2025

As in the title.

Benchmark can be done as follows

sage: from sage.doctest.util import ensure_interruptible_after
sage: R.<x> = CDF[]
sage: f = R.random_element(degree=5000)
sage: g = R.random_element(degree=5000)
sage: %time h = f*f
sage: %time h = f*g

The first one takes ≈ 2.32s and the second one takes ≈ 2.9s on my machine. Additional slowdown is within measurement error anyway (certainly checking a single bool is faster than constructing a new Python object).

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

Copy link

github-actions bot commented Apr 5, 2025

Documentation preview for this PR (built with commit f551516; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant